From 9f22d7a445cfbd4917c31344897ddd68afc26748 Mon Sep 17 00:00:00 2001 From: wan Date: Mon, 19 Aug 2019 11:34:40 +0000 Subject: [PATCH] [FIX] base: same vat with empty string vat If partner.vat is an empty string, python evaluates it as falsy and doesn't check the remaining of the line. This makes the framework to send ["", ""] as values for the many2one to the browser instead of false. By forcing to have True or False, this is not a problem anymore as bool() will be False, and False will result in the correct value in the read. closes odoo/odoo#35807 Signed-off-by: Quentin De Paoli (qdp) --- odoo/addons/base/models/res_partner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/odoo/addons/base/models/res_partner.py b/odoo/addons/base/models/res_partner.py index 714f4841fb5..2a8f9f7c8cb 100644 --- a/odoo/addons/base/models/res_partner.py +++ b/odoo/addons/base/models/res_partner.py @@ -273,7 +273,7 @@ class Partner(models.Model): domain = [('vat', '=', partner.vat)] if partner_id: domain += [('id', '!=', partner_id), '!', ('id', 'child_of', partner_id)] - partner.same_vat_partner_id = partner.vat and not partner.parent_id and self.env['res.partner'].search(domain, limit=1) + partner.same_vat_partner_id = bool(partner.vat) and not partner.parent_id and self.env['res.partner'].search(domain, limit=1) @api.depends(lambda self: self._display_address_depends()) def _compute_contact_address(self):