From 9ec0fb5e37e6919f088643c33ce16aae375f7bf2 Mon Sep 17 00:00:00 2001 From: ced <> Date: Mon, 23 Jul 2007 05:15:40 +0000 Subject: [PATCH] crm: fix bad practice of default value In python the default value is instanciate only once. So if the code modify the default value, it is also for all calls that comes after. Good practice is to not use [] nor {} as default value, but use instead None or False. bzr revid: ced-240a55be30f4d38046ca6b310967ad7742dd717e --- addons/crm/crm.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/crm/crm.py b/addons/crm/crm.py index 836e5512b52..fcb762a1a65 100644 --- a/addons/crm/crm.py +++ b/addons/crm/crm.py @@ -264,7 +264,9 @@ class crm_case(osv.osv): 'date': lambda *a: time.strftime('%Y-%m-%d %H:%M:%S'), } _order = 'priority, date_deadline desc, id desc' - def _action(self, cr, uid, cases, state_to, scrit=[], context={}): + def _action(self, cr, uid, cases, state_to, scrit=None, context={}): + if not scrit: + scrit = [] action_ids = self.pool.get('crm.case.rule').search(cr, uid, scrit) level = MAX_LEVEL while len(action_ids) and level: