[FIX] *: incorrect translations markings
Fixes a large number of cases where strings are translated then
formatted, instead of letting `_()` do the formatting internally,
which allows it to recover from incorrect translations (missing,
broken, or extra placeholders).
Also
- removes translation markers entirely when there's nothing to
translate e.g. `_("%s - %s")` is not useful
- fixes a few messes which lead to only partial translatability
(DRY is generally a bad idea when translations are involved, even
more so when you don't make the variable part translatable)
- fixes a few nearby issues noticed at the same time
- replaces a few `"%s"` by `%r`, which should automatically quote
strings relatively appropriately
- fixes translated strings which use `\` to escape a newline (in order
to fill-paragraph): `\` escapes only the newline, if the
continuation string is indented this results in a bunch of spaces
ending in the string to translate, which is pretty garbage for the
translator, using implicit concatenation works much better
Note: some of the updates revert f-string parameters to %, because
babel (2.9) apparently has trouble with f-strings and blows up trying
to extract them.
Not in scope:
Helping translators fix translatable strings e.g. any translation
string with more than one placeholder probably should use keyword
placeholders
- Provides more context / data to the translator to make sense of the
sentence.
- Allows reordering the translated terms, which can be necessary
depending on the sentence and language.
closes odoo/odoo#139314
Related: odoo/enterprise#49311
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
This commit is contained in:
@@ -245,7 +245,7 @@ class HrEmployeePrivate(models.Model):
|
||||
public_fields = self.env['hr.employee.public']._fields
|
||||
private_fields = [fname for fname in field_names if fname not in public_fields]
|
||||
if private_fields:
|
||||
raise AccessError(_('The fields "%s" you try to read is not available on the public employee profile.') % (','.join(private_fields)))
|
||||
raise AccessError(_('The fields %r you try to read is not available on the public employee profile.', ','.join(private_fields)))
|
||||
|
||||
def _copy_cache_from(self, public, field_names):
|
||||
# HACK: retrieve publicly available values from hr.employee.public and
|
||||
|
||||
@@ -54,7 +54,7 @@ class Job(models.Model):
|
||||
self.ensure_one()
|
||||
default = dict(default or {})
|
||||
if 'name' not in default:
|
||||
default['name'] = _("%s (copy)") % (self.name)
|
||||
default['name'] = _("%s (copy)", self.name)
|
||||
return super(Job, self).copy(default=default)
|
||||
|
||||
def write(self, vals):
|
||||
|
||||
Reference in New Issue
Block a user