From 9ebbceeb658b15ba3f7ba0dc098b01baabe0624c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Fri, 11 Dec 2015 13:56:20 +0100 Subject: [PATCH] [FIX] project, issue: stop spamming partners Commit bb1200adc781efc1318e502a84cc1e77315aabc4 introduced the automatic addition of cc as followers of tasks and issues. However it seems to automatically create partners if the address it not recognized. This does not seem a good idea. --- addons/project/project.py | 4 ++-- addons/project_issue/project_issue.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/project/project.py b/addons/project/project.py index 4e9a6c879c9..6cfcb9e243e 100644 --- a/addons/project/project.py +++ b/addons/project/project.py @@ -806,7 +806,7 @@ class task(osv.osv): res = super(task, self).message_new(cr, uid, msg, custom_values=defaults, context=context) email_list = self.email_split(cr, uid, [res], msg, context=context) - partner_ids = self._find_partner_from_emails(cr, uid, [res], email_list, force_create=True, context=context) + partner_ids = filter(None, self._find_partner_from_emails(cr, uid, [res], email_list, force_create=False, context=context)) self.message_subscribe(cr, uid, [res], partner_ids, context=context) return res @@ -830,7 +830,7 @@ class task(osv.osv): pass email_list = self.email_split(cr, uid, ids, msg, context=context) - partner_ids = self._find_partner_from_emails(cr, uid, ids, email_list, force_create=True, context=context) + partner_ids = filter(None, self._find_partner_from_emails(cr, uid, ids, email_list, force_create=False, context=context)) self.message_subscribe(cr, uid, ids, partner_ids, context=context) return super(task, self).message_update(cr, uid, ids, msg, update_vals=update_vals, context=context) diff --git a/addons/project_issue/project_issue.py b/addons/project_issue/project_issue.py index fa43aee4203..21d1a8595e9 100644 --- a/addons/project_issue/project_issue.py +++ b/addons/project_issue/project_issue.py @@ -397,7 +397,7 @@ class project_issue(osv.Model): res_id = super(project_issue, self).message_new(cr, uid, msg, custom_values=defaults, context=context) email_list = self.email_split(cr, uid, [res_id], msg, context=context) - partner_ids = self._find_partner_from_emails(cr, uid, [res_id], email_list, force_create=True, context=context) + partner_ids = filter(None, self._find_partner_from_emails(cr, uid, [res_id], email_list, force_create=False, context=context)) self.message_subscribe(cr, uid, [res_id], partner_ids, context=context) return res_id @@ -405,7 +405,7 @@ class project_issue(osv.Model): """ Override to update the issue according to the email. """ email_list = self.email_split(cr, uid, ids, msg, context=context) - partner_ids = self._find_partner_from_emails(cr, uid, ids, email_list, force_create=True, context=context) + partner_ids = filter(None, self._find_partner_from_emails(cr, uid, ids, email_list, force_create=False, context=context)) self.message_subscribe(cr, uid, ids, partner_ids, context=context) return super(project_issue, self).message_update(cr, uid, ids, msg, update_vals=update_vals, context=context)