From 9e7c5537d243335b6adbdb2cf5fcb5423c203a37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Wed, 6 Mar 2019 13:48:22 +0000 Subject: [PATCH] [FIX] website_slides: fix set viewed slide Currently a slide that can be previewed is never set as completed. Correct condition to not update the hard slide-partner relationship is: * either current user is public; * either current slide is not published (happens when a publisher sees still unpublished lessons); * either current user is not member of slide channel (happens when seeing a free preview slide without being channel member); Commit linked to task ID 1941250 and PR #31512. --- addons/website_slides/controllers/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_slides/controllers/main.py b/addons/website_slides/controllers/main.py index 1f3e78c4a16..087ed6919fa 100644 --- a/addons/website_slides/controllers/main.py +++ b/addons/website_slides/controllers/main.py @@ -52,7 +52,7 @@ class WebsiteSlides(WebsiteProfile): return {'slide': slide} def _set_viewed_slide(self, slide): - if request.env.user._is_public() or slide.is_preview or not slide.channel_id.is_member: + if request.env.user._is_public() or not slide.website_published or not slide.channel_id.is_member: viewed_slides = request.session.setdefault('viewed_slides', list()) if slide.id not in viewed_slides: slide.sudo().public_views += 1