From 9e780ab711b2abcb80b29271ba793f5b8686b3ab Mon Sep 17 00:00:00 2001
From: Nikunj Ladava <nla@odoo.com>
Date: Thu, 22 Jun 2017 16:20:56 +0530
Subject: [PATCH] [REF] website_twitter: remove modal xml from view

The twitter settings view contained a link which opened an inline modal
with a tutorial. As inline modals are not supposed to be supported by
the backend (the Dialog JS class should always be used), this is removed
and replaced by a link to the online Odoo twitter documentation.
---
 .../views/website_twitter_settings_views.xml  | 40 +------------------
 1 file changed, 2 insertions(+), 38 deletions(-)

diff --git a/addons/website_twitter/views/website_twitter_settings_views.xml b/addons/website_twitter/views/website_twitter_settings_views.xml
index 7e8e92a1f47..b8cc0293551 100644
--- a/addons/website_twitter/views/website_twitter_settings_views.xml
+++ b/addons/website_twitter/views/website_twitter_settings_views.xml
@@ -21,49 +21,13 @@
                             <field name="twitter_screen_name" class="oe_inline"/>
                         </div>
                         <div>
-                            <a data-toggle="modal" class="oe_link fa fa-arrow-right" href="#" data-target="#twitter_tutorial">
-                                Tutorial
+                            <a class="oe_link" href="https://www.odoo.com/documentation/user/11.0/discuss/mail_twitter.html" target="_blank">
+                                <i class="fa fa-arrow-right"/> Tutorial
                             </a>
                         </div>
                     </div>
                 </div>
             </div>
-            <form class="oe_form_configuration">
-                <div id="twitter_tutorial" class="modal fade" role="dialog" tabindex="-1">
-                    <div class="modal-dialog" role="document">
-                        <div class="modal-content">
-                            <div class="modal-header">
-                                <a class="close" data-dismiss="modal" aria-hidden="true">×</a>
-                                <h3 class="modal-title">How to configure the Twitter API access</h3>
-                            </div>
-                            <div class="modal-body">
-                                <ol>
-                                    <li>Create a new Twitter application on <a href="https://apps.twitter.com/" target="new">
-                                            https://apps.twitter.com/
-                                        </a>
-                                        with the following values:
-                                       <ul>
-                                          <li><strong>Name: </strong> Odoo Tweet Scroller</li>
-                                          <li><strong>Description: </strong> Odoo Tweet Scroller </li>
-                                          <li><strong>Website: </strong> <tt>https://www.odoo.com</tt></li>
-                                          <li><strong>Callback URL: </strong> leave it blank</li>
-                                          <li>Accept terms of use and click on the Create button at the bottom</li>
-                                       </ul>
-                                    </li>
-                                    <li>Switch to the API Keys tab: <br/>
-                                        <img src='/website_twitter/static/src/img/api_key.png'/>
-                                    </li>
-                                    <li>Copy/Paste API Key and Secret below</li>
-                                    <li>Enter the screen name from which you want to load favorite Tweets (does not need to be the same as the API keys)</li>
-                                </ol>
-                            </div>
-                            <div class="modal-footer">
-                                <a type="button" class="btn btn-primary" data-dismiss="modal">Close</a>
-                            </div>
-                        </div>
-                    </div>
-                </div>
-            </form>
         </field>
     </record>
 </odoo>