From 9de1bc0eef6f5bfaa2a8d745431caa361ae91548 Mon Sep 17 00:00:00 2001 From: kujiu Date: Fri, 22 Jun 2018 21:22:21 +0200 Subject: [PATCH] [IMP] Improve compatibility with screen readers (accessibility) (#24574) Today, Odoo is really tricky to use without seeing the screen, it must be improved to be usable. This PR forbid to use labels without a "for" attribute, add some title, rule and aria attributes in HTML. With that, Odoo will be fully usable with a screen reader. * [IMP] Labels must have a for attribute. Improve accessibility. * [IMP] Better error message when trying to read a missing cached value * [FIX] Add some aria-label and title attributes for screen readers. * [FIX] Template name is not included in the error message in case of SyntaxError in QWeb * [FIX] Improve the Tour failed at step error message to be more explicit. * [IMP] Add aria-labels * [FIX] Add missing aria-label on failing test * [IMP] aria-hidden means hidden. Fix all bad aria-hidden and hide aria-hidden for all. * [IMP] Color names on kanban views and many2many tags * [IMP] Add some checks on views for accessibility. * [IMP] Add `alt` attribute on `img` tags. * [IMP] Add aria-label and title on non-described icons * [IMP] Add button role to widgets with btn class * [IMP] Translate aria and formatted attributes. * [IMP] Remove wrong aria-labelledby * [IMP] Add menu role on dropdowns * [IMP] Buttons must be focusable * [IMP] Add aria attributes on progress bars * [IMP] Improve accessibility of basic widgets * [IMP] Change main layout to more semantic tags * [IMP] Add menuitem role when missing * [IMP] Remove wrong role='presentation' * [IMP] Improve accessibility of tab panels * [IMP] Add aria-invalid on invalid fields * [IMP] Add aria-sort on ordered columns * [IMP] Add role on alerts * [IMP] Use dialog role, header, main and footer tags for modals * [IMP] Add labels on o_status * [IMP] Improve accessibility of kanban view with feeds and articles * [IMP] Add alerts in case of new messages * [IMP] Add widget, navigation or img role to aria-labelled items --- .../src/xml/account_dashboard_setup_bar.xml | 10 +- .../static/src/xml/account_payment.xml | 2 +- .../static/src/xml/account_reconciliation.xml | 34 +- .../static/tests/reconciliation_tests.js | 8 +- addons/account/views/account_invoice_view.xml | 18 +- .../views/account_journal_dashboard_view.xml | 34 +- addons/account/views/account_payment_view.xml | 6 +- .../views/account_portal_templates.xml | 14 +- addons/account/views/account_view.xml | 22 +- .../views/res_config_settings_views.xml | 44 +- ...count_report_aged_partner_balance_view.xml | 2 +- .../wizard/account_unreconcile_view.xml | 2 +- .../wizard/account_validate_move_view.xml | 2 +- .../views/account_analytic_default_view.xml | 4 +- .../views/account_budget_views.xml | 4 +- .../views/account_portal_templates.xml | 8 +- .../auth_oauth/views/auth_oauth_templates.xml | 2 +- .../views/res_config_settings_views.xml | 2 +- .../views/auth_signup_login_templates.xml | 18 +- addons/auth_signup/views/res_users_views.xml | 4 +- .../static/src/js/barcode_form_view.js | 2 +- addons/barcodes/static/tests/barcode_tests.js | 10 +- .../base_gengo/views/ir_translation_views.xml | 2 +- .../wizard/base_gengo_translations_view.xml | 4 +- .../static/src/xml/base_import.xml | 6 +- .../tests/test_module/test.xml | 2 +- .../views/base_import_module_view.xml | 2 +- .../views/res_config_settings_views.xml | 11 +- .../views/res_config_settings_views.xml | 2 +- addons/board/static/src/xml/board.xml | 6 +- addons/board/static/tests/dashboard_tests.js | 16 +- .../calendar/static/tests/calendar_tests.js | 10 +- addons/calendar/views/calendar_templates.xml | 2 +- addons/calendar/views/calendar_views.xml | 2 +- addons/crm/data/mail_template_data.xml | 2 +- addons/crm/static/src/js/tour.js | 4 +- addons/crm/views/crm_lead_views.xml | 22 +- addons/crm/views/crm_team_views.xml | 2 +- .../crm/views/res_config_settings_views.xml | 6 +- addons/crm/views/res_partner_views.xml | 4 +- addons/delivery/views/delivery_view.xml | 6 +- .../document/static/tests/document_tests.js | 2 +- addons/event/data/email_template_data.xml | 24 +- addons/event/report/event_event_templates.xml | 8 +- addons/event/views/event_views.xml | 11 +- addons/event/wizard/event_confirm_view.xml | 2 +- addons/event_sale/data/event_demo.xml | 4 +- .../fleet/views/fleet_vehicle_model_views.xml | 4 +- addons/fleet/views/fleet_vehicle_views.xml | 6 +- addons/gamification/views/badge.xml | 6 +- addons/gamification/views/challenge.xml | 2 +- addons/gamification/views/goal.xml | 8 +- .../views/res_config_settings_views.xml | 2 +- .../views/res_config_settings_views.xml | 4 +- addons/hr/views/hr_views.xml | 30 +- addons/hr/views/res_config_settings_views.xml | 2 +- .../report/hr_employee_badge.xml | 4 +- .../static/src/xml/attendance.xml | 28 +- .../views/hr_attendance_view.xml | 4 +- .../hr_attendance/views/hr_employee_view.xml | 14 +- .../views/res_config_settings_views.xml | 2 +- .../hr_contract/views/hr_contract_views.xml | 10 +- .../views/res_config_settings_views.xml | 2 +- .../hr_holidays/report/hr_leave_reports.xml | 2 +- .../views/hr_leave_allocation_views.xml | 3 +- .../views/maintenance_views.xml | 2 +- .../static/src/xml/hr_org_chart.xml | 6 +- .../views/res_config_settings_views.xml | 2 +- ...hr_payroll_payslips_by_employees_views.xml | 2 +- .../data/hr_recruitment_data.xml | 4 +- addons/hr_recruitment/views/hr_job_views.xml | 20 +- .../views/hr_recruitment_views.xml | 18 +- .../views/res_config_settings_views.xml | 4 +- .../hr_timesheet/views/hr_timesheet_views.xml | 4 +- addons/hr_timesheet/views/project_views.xml | 2 +- addons/iap/static/src/xml/iap_templates.xml | 4 +- .../static/src/xml/copy_clipboard.xml | 4 +- .../static/src/xml/im_livechat_backend.xml | 3 +- .../views/im_livechat_channel_views.xml | 16 +- .../views/l10n_be_hr_payroll_view.xml | 4 +- .../views/res_config_settings_views.xml | 2 +- .../views/res_config_settings_views.xml | 2 +- .../views/res_config_settings_views.xml | 4 +- .../hr_salary_employee_bymonth_view.xml | 2 +- .../wizard/hr_yearly_salary_detail_view.xml | 2 +- addons/lunch/static/src/xml/lunch.xml | 3 +- addons/lunch/views/lunch_views.xml | 38 +- addons/mail/static/src/xml/activity.xml | 26 +- addons/mail/static/src/xml/chat_window.xml | 12 +- addons/mail/static/src/xml/chatter.xml | 8 +- addons/mail/static/src/xml/composer.xml | 24 +- addons/mail/static/src/xml/discuss.xml | 42 +- .../static/src/xml/extended_chat_window.xml | 2 +- addons/mail/static/src/xml/followers.xml | 32 +- addons/mail/static/src/xml/systray.xml | 25 +- addons/mail/static/src/xml/thread.xml | 70 +- .../static/src/xml/web_kanban_activity.xml | 32 +- addons/mail/static/tests/chatter_tests.js | 36 +- .../static/tests/discuss_moderation_tests.js | 2 +- addons/mail/views/mail_channel_views.xml | 4 +- addons/mail/views/mail_message_views.xml | 2 +- .../mail/views/res_config_settings_views.xml | 2 +- .../mail/wizard/mail_resend_message_views.xml | 2 +- .../maintenance/views/maintenance_views.xml | 58 +- .../mass_mailing/data/mass_mailing_demo.xml | 4 +- .../static/src/xml/mass_mailing.xml | 12 +- .../mass_mailing/views/editor_field_html.xml | 2 +- .../views/mass_mailing_stats_views.xml | 2 +- .../mass_mailing/views/mass_mailing_views.xml | 36 +- addons/mass_mailing/views/snippets_themes.xml | 52 +- .../views/snippets_themes_options.xml | 4 +- addons/membership/views/product_views.xml | 4 +- .../mrp/report/mrp_production_templates.xml | 4 +- .../mrp/report/mrp_report_bom_structure.xml | 6 +- addons/mrp/views/ir_attachment_view.xml | 2 +- addons/mrp/views/mrp_bom_views.xml | 4 +- addons/mrp/views/mrp_workcenter_views.xml | 25 +- addons/mrp/views/mrp_workorder_views.xml | 8 +- .../mrp/views/res_config_settings_views.xml | 2 +- addons/mrp/views/stock_picking_views.xml | 22 +- addons/note/static/src/xml/systray.xml | 8 +- addons/note/views/note_views.xml | 14 +- addons/pad/static/src/xml/pad.xml | 2 +- addons/pad/static/tests/pad_tests.js | 4 +- addons/payment/data/payment_acquirer_data.xml | 48 +- addons/payment/static/src/js/payment_form.js | 8 +- .../views/payment_portal_templates.xml | 24 +- addons/payment/views/payment_templates.xml | 8 +- addons/payment/views/payment_views.xml | 2 +- .../static/src/xml/stripe_templates.xml | 18 +- addons/point_of_sale/static/src/js/screens.js | 11 + addons/point_of_sale/static/src/xml/pos.xml | 218 +- .../views/point_of_sale_dashboard.xml | 16 +- .../point_of_sale/views/pos_category_view.xml | 2 +- .../point_of_sale/views/pos_config_view.xml | 6 +- addons/point_of_sale/views/pos_order_view.xml | 2 +- .../point_of_sale/views/pos_session_view.xml | 2 +- addons/point_of_sale/views/pos_templates.xml | 2 +- .../point_of_sale/views/report_userlabel.xml | 2 +- .../views/res_config_settings_views.xml | 2 +- .../point_of_sale/views/res_partner_view.xml | 2 +- .../wizard/pos_open_statement.xml | 2 +- .../portal/static/src/xml/portal_chatter.xml | 8 +- .../static/src/xml/portal_signature.xml | 4 +- addons/portal/views/portal_templates.xml | 13 +- .../static/src/xml/discount_templates.xml | 2 +- .../static/src/xml/pos_mercury.xml | 2 +- .../views/pos_config_setting_views.xml | 2 +- addons/pos_reprint/static/src/xml/reprint.xml | 5 +- .../pos_restaurant/static/src/xml/floors.xml | 64 +- .../static/src/xml/multiprint.xml | 3 +- .../pos_restaurant/static/src/xml/notes.xml | 4 +- .../static/src/xml/printbill.xml | 13 +- .../static/src/xml/splitbill.xml | 8 +- .../pos_restaurant/views/pos_config_views.xml | 12 +- .../report/product_product_templates.xml | 6 +- .../product/views/product_pricelist_views.xml | 4 +- .../product/views/product_template_views.xml | 2 +- addons/product/views/product_views.xml | 2 +- .../data/product_demo.xml | 4 +- .../data/project_mail_template_data.xml | 2 +- addons/project/static/src/js/tour.js | 2 +- addons/project/static/src/xml/project.xml | 2 +- addons/project/static/tests/project_tests.js | 6 +- .../views/project_portal_templates.xml | 6 +- .../views/project_rating_templates.xml | 29 +- addons/project/views/project_views.xml | 64 +- addons/purchase/views/portal_templates.xml | 4 +- addons/purchase/views/purchase_views.xml | 6 +- .../views/res_config_settings_views.xml | 4 +- addons/purchase/views/res_partner_views.xml | 2 +- .../views/purchase_requisition_views.xml | 2 +- addons/purchase_stock/data/mail_data.xml | 2 +- addons/rating/views/rating_template.xml | 6 +- addons/rating/views/rating_view.xml | 4 +- addons/repair/wizard/repair_cancel_views.xml | 2 +- .../sale/views/res_config_settings_views.xml | 4 +- addons/sale/views/res_partner_views.xml | 2 +- addons/sale/views/sale_portal_templates.xml | 30 +- .../sale_make_invoice_advance_views.xml | 4 +- addons/sale_management/static/src/js/tour.js | 7 +- .../views/sale_portal_templates.xml | 12 +- addons/sale_stock/static/src/js/tour.js | 6 +- .../views/res_config_settings_views.xml | 2 +- .../views/sale_stock_portal_template.xml | 10 +- .../views/stock_config_settings_views.xml | 4 +- addons/sale_stock/views/stock_views.xml | 4 +- .../views/hr_timesheet_templates.xml | 2 +- .../views/res_config_settings_views.xml | 2 +- addons/sales_team/views/crm_team_views.xml | 4 +- .../sales_team/views/sales_team_dashboard.xml | 18 +- addons/sms/static/src/xml/sms_widget.xml | 2 +- addons/sms/views/res_partner_views.xml | 4 + .../stock/report/report_location_barcode.xml | 2 +- addons/stock/report/report_lot_barcode.xml | 6 +- .../stock/report/report_package_barcode.xml | 4 +- .../report/report_stockpicking_operations.xml | 12 +- .../xml/stock_traceability_report_backend.xml | 12 +- .../xml/stock_traceability_report_line.xml | 6 +- .../stock/views/report_stock_traceability.xml | 4 +- addons/stock/views/stock_inventory_views.xml | 2 +- addons/stock/views/stock_move_views.xml | 2 +- addons/stock/views/stock_picking_views.xml | 24 +- addons/stock/views/stock_scrap_views.xml | 2 +- addons/stock/views/stock_template.xml | 2 +- .../views/stock_account_views.xml | 2 +- .../views/stock_landed_cost_views.xml | 2 +- .../views/stock_picking_batch_views.xml | 2 +- addons/survey/views/survey_result.xml | 65 +- addons/survey/views/survey_templates.xml | 22 +- addons/survey/views/survey_views.xml | 44 +- .../views/theme_bootswatch_templates.xml | 10 +- .../views/theme_default_templates.xml | 12 +- .../fontawesome/css/font-awesome-suffix.css | 2145 +++++++++++++++++ addons/web/static/lib/pdfjs/web/ui_utils.js | 6 + .../static/lib/qweb/qweb-test-attributes.xml | 4 +- addons/web/static/lib/qweb/qweb2.js | 4 +- addons/web/static/src/js/core/dialog.js | 31 +- .../static/src/js/fields/abstract_field.js | 2 + .../web/static/src/js/fields/basic_fields.js | 22 +- .../static/src/js/fields/relational_fields.js | 2 +- .../src/js/views/basic/basic_renderer.js | 1 + .../views/kanban/kanban_column_progressbar.js | 3 + .../kanban/kanban_column_quick_create.js | 2 +- .../src/js/views/kanban/kanban_record.js | 31 +- .../kanban/kanban_record_quick_create.js | 2 +- .../js/views/list/list_editable_renderer.js | 6 +- .../static/src/js/views/list/list_renderer.js | 4 + .../src/js/views/pivot/pivot_renderer.js | 5 + .../static/src/js/widgets/change_password.js | 2 +- .../static/src/js/widgets/debug_manager.js | 2 +- .../src/js/widgets/domain_selector_dialog.js | 2 +- addons/web/static/src/scss/ui.scss | 4 + addons/web/static/src/scss/utils.scss | 8 + addons/web/static/src/xml/base.xml | 414 ++-- addons/web/static/src/xml/dialog.xml | 12 +- addons/web/static/src/xml/kanban.xml | 43 +- addons/web/static/src/xml/web_calendar.xml | 18 +- .../tests/chrome/action_manager_tests.js | 18 +- .../static/tests/fields/basic_fields_tests.js | 10 +- .../tests/fields/relational_fields_tests.js | 508 ++-- .../tests/fields/upgrade_fields_tests.js | 2 +- .../services/notification_service_tests.js | 6 +- .../web/static/tests/views/calendar_tests.js | 104 +- addons/web/static/tests/views/form_tests.js | 184 +- addons/web/static/tests/views/kanban_tests.js | 62 +- addons/web/static/tests/views/list_tests.js | 16 +- .../static/tests/views/view_dialogs_tests.js | 14 +- .../static/tests/widgets/data_export_tests.js | 28 +- addons/web/views/database_manager.html | 1 + addons/web/views/report_templates.xml | 17 +- addons/web/views/webclient_templates.xml | 50 +- .../web_diagram/static/tests/diagram_tests.js | 22 +- .../static/lib/summernote/src/js/Renderer.js | 14 +- .../static/src/js/backend/fields.js | 2 +- addons/web_editor/static/src/js/tours/rte.js | 8 +- .../static/src/js/widgets/widgets.js | 2 +- addons/web_editor/static/src/xml/ace.xml | 6 +- addons/web_editor/static/src/xml/backend.xml | 4 +- addons/web_editor/static/src/xml/editor.xml | 65 +- addons/web_editor/static/src/xml/snippets.xml | 18 +- addons/web_editor/views/snippets.xml | 2 +- .../static/src/xml/dashboard.xml | 32 +- addons/web_tour/static/src/js/tour_manager.js | 16 +- .../web_tour/static/src/xml/debug_manager.xml | 2 +- addons/website/data/website_data.xml | 2 +- addons/website/data/website_demo.xml | 12 +- .../src/js/content/snippets.animation.js | 2 +- .../website/static/src/js/menu/mobile_view.js | 2 +- addons/website/static/src/js/tours/rte.js | 12 +- .../static/src/xml/website.backend.xml | 2 +- .../static/src/xml/website.contentMenu.xml | 10 +- .../static/src/xml/website.facebook_page.xml | 4 +- .../static/src/xml/website.gallery.xml | 18 +- .../static/src/xml/website.pageProperties.xml | 18 +- addons/website/static/src/xml/website.seo.xml | 2 +- .../website/static/src/xml/website.share.xml | 2 +- addons/website/static/src/xml/website.xml | 18 +- .../views/res_config_settings_views.xml | 6 +- addons/website/views/snippets.xml | 244 +- .../views/website_navbar_templates.xml | 42 +- addons/website/views/website_templates.xml | 78 +- addons/website/views/website_views.xml | 4 +- .../website_blog/data/website_blog_demo.xml | 6 +- .../static/src/js/website.tour.blog.js | 8 +- addons/website_blog/views/snippets.xml | 34 +- .../views/website_blog_templates.xml | 56 +- .../website_blog/views/website_blog_views.xml | 4 +- .../views/website_crm_templates.xml | 8 +- .../website_crm_partner_assign_templates.xml | 124 +- .../views/website_customer_templates.xml | 12 +- .../static/src/js/website.tour.event.js | 6 +- .../static/src/js/website_event.js | 2 +- .../website_event/views/event_templates.xml | 77 +- .../views/event_templates.xml | 2 +- .../views/event_track_templates.xml | 2 +- .../views/event_track_views.xml | 14 +- .../static/src/xml/website_form.xml | 6 +- .../static/src/js/website_tour_forum.js | 6 +- .../src/xml/website_forum_share_templates.xml | 21 +- addons/website_forum/views/ir_qweb.xml | 6 +- addons/website_forum/views/website_forum.xml | 191 +- addons/website_forum_doc/views/doc.xml | 12 +- .../website_forum_doc/views/website_doc.xml | 6 +- .../static/src/xml/website.gengo.xml | 82 +- .../website_hr/views/website_hr_templates.xml | 2 +- .../data/hr_job_demo.xml | 56 +- .../website_hr_recruitment_templates.xml | 52 +- .../views/website_hr_recuitment_snippets.xml | 24 +- .../static/src/xml/recent_link.xml | 10 +- .../views/website_links_graphs.xml | 16 +- .../views/website_links_template.xml | 12 +- .../views/res_config_settings_views.xml | 2 +- .../views/website_livechat.xml | 6 +- .../website_mail/data/mail_channel_data.xml | 2 +- .../website_mail_channel/views/snippets.xml | 8 +- .../views/website_mail_channel_templates.xml | 44 +- .../views/snippets_templates.xml | 26 +- .../views/unsubscribe_templates.xml | 6 +- .../views/website_membership_templates.xml | 10 +- .../website_quote/data/website_quote_demo.xml | 26 +- .../views/website_quote_templates.xml | 146 +- .../static/src/xml/website_mail.xml | 18 +- addons/website_sale/data/demo.xml | 36 +- .../website_sale/data/mail_template_data.xml | 2 +- .../static/src/js/website_sale_tour_shop.js | 8 +- addons/website_sale/views/product_views.xml | 2 +- .../views/res_config_settings_views.xml | 12 +- addons/website_sale/views/snippets.xml | 20 +- addons/website_sale/views/templates.xml | 134 +- .../static/src/xml/comparison.xml | 10 +- .../website_sale_comparison_template.xml | 16 +- .../views/website_sale_digital.xml | 4 +- .../xml/website_sale_dashboard_utm_chart.xml | 8 +- .../static/src/js/website_sale.test.js | 2 +- .../views/website_sale_options_templates.xml | 28 +- ...ebsite_sale_stock_product_availability.xml | 4 +- .../views/website_sale_stock_templates.xml | 8 +- .../views/website_sale_wishlist_template.xml | 15 +- .../static/src/js/slides_upload.js | 4 +- .../static/src/xml/website_slides.xml | 24 +- .../views/res_config_settings_views.xml | 7 +- .../website_slides/views/website_slides.xml | 124 +- .../views/website_slides_backend.xml | 2 +- .../views/website_slides_embed.xml | 34 +- addons/website_theme_install/views/views.xml | 8 +- .../static/src/xml/website.twitter.xml | 6 +- .../views/res_config_settings_views.xml | 4 +- odoo/addons/base/models/ir_ui_view.py | 7 +- odoo/addons/base/rng/common.rng | 3 + .../addons/base/tests/test_view_validation.py | 75 +- odoo/addons/base/views/ir_module_views.xml | 2 +- .../base/views/ir_qweb_widget_templates.xml | 14 +- odoo/addons/base/views/ir_rule_views.xml | 2 +- odoo/addons/base/views/ir_sequence_views.xml | 22 +- odoo/addons/base/views/res_company_views.xml | 4 +- .../base/views/res_config_settings_views.xml | 2 +- odoo/addons/base/views/res_partner_views.xml | 22 +- odoo/addons/base/views/res_users_views.xml | 12 +- .../wizard/base_language_install_views.xml | 4 +- .../wizard/base_module_uninstall_views.xml | 2 +- .../base/wizard/base_module_update_views.xml | 2 +- .../base/wizard/base_module_upgrade_views.xml | 4 +- odoo/addons/test_exceptions/view.xml | 46 +- .../test_main_flows/static/src/js/tour.js | 46 +- .../test_new_api/static/tests/x2many.js | 32 +- odoo/api.py | 7 +- odoo/exceptions.py | 7 + odoo/tools/translate.py | 5 +- odoo/tools/view_validation.py | 242 +- 370 files changed, 5804 insertions(+), 3218 deletions(-) create mode 100644 addons/web/static/lib/fontawesome/css/font-awesome-suffix.css diff --git a/addons/account/static/src/xml/account_dashboard_setup_bar.xml b/addons/account/static/src/xml/account_dashboard_setup_bar.xml index 7666753f26b..8b065bc7829 100644 --- a/addons/account/static/src/xml/account_dashboard_setup_bar.xml +++ b/addons/account/static/src/xml/account_dashboard_setup_bar.xml @@ -6,22 +6,22 @@
@@ -29,7 +29,7 @@

Configuration Steps

- +
diff --git a/addons/account/static/src/xml/account_payment.xml b/addons/account/static/src/xml/account_payment.xml index 0a8abf28d72..27fc4044f24 100644 --- a/addons/account/static/src/xml/account_payment.xml +++ b/addons/account/static/src/xml/account_payment.xml @@ -22,7 +22,7 @@ - + Paid on diff --git a/addons/account/static/src/xml/account_reconciliation.xml b/addons/account/static/src/xml/account_reconciliation.xml index a367feb03c0..0183aecebc7 100644 --- a/addons/account/static/src/xml/account_reconciliation.xml +++ b/addons/account/static/src/xml/account_reconciliation.xml @@ -81,7 +81,7 @@ - + () @@ -120,7 +120,7 @@ - + Last Reconciliation: @@ -130,12 +130,12 @@ - + Create Write-offOpen balanceChoose counterpart - - + + @@ -144,8 +144,8 @@
- - + +
@@ -163,10 +163,10 @@

To speed up reconciliation, define reconciliation models.

- -
@@ -205,14 +205,14 @@
- Save and New + Save and New
- + @@ -225,8 +225,8 @@ : - - + + @@ -266,10 +266,10 @@
- + - diff --git a/addons/account/static/tests/reconciliation_tests.js b/addons/account/static/tests/reconciliation_tests.js index 0ef3ec63b6e..45cbc30d8ea 100644 --- a/addons/account/static/tests/reconciliation_tests.js +++ b/addons/account/static/tests/reconciliation_tests.js @@ -941,11 +941,11 @@ QUnit.module('account', { // Simulate changing partner with SelectCreateDialog widget = clientAction.widgets[1]; - assert.strictEqual($('.modal').length, 0, "shouldn't have any opened modal"); + assert.strictEqual($('[role="dialog"]').length, 0, "shouldn't have any opened modal"); widget.$('.o_input_dropdown input').trigger('click'); $('.ui-autocomplete .ui-menu-item a:contains(Search More):eq(1)').trigger('mouseenter').trigger('click'); - assert.strictEqual($('.modal').length, 1, "should open a SelectCreateDialog"); - $('.modal table.o_list_view td:contains(Camptocamp)').click(); + assert.strictEqual($('[role="dialog"]').length, 1, "should open a SelectCreateDialog"); + $('[role="dialog"] table.o_list_view td:contains(Camptocamp)').click(); assert.strictEqual(widget.$('.o_input_dropdown input').val(), "Camptocamp", "the partner many2one should display Camptocamp"); widget = clientAction.widgets[2]; @@ -1100,7 +1100,7 @@ QUnit.module('account', { widget.$('.create .create_account_id input').trigger('click'); $('.ui-autocomplete .ui-menu-item a:contains(Search)').trigger('mouseenter').trigger('click'); // select the account who does not appear in the drop drown - $('.modal tr.o_data_row:contains(502)').click(); + $('[role="dialog"] tr.o_data_row:contains(502)').click(); assert.strictEqual(widget.$('.create .create_account_id input').val(), "101200 Account Receivable", "Selected account does not change"); // wait the name_get to render the changes def.resolve(); diff --git a/addons/account/views/account_invoice_view.xml b/addons/account/views/account_invoice_view.xml index 8345b94ac58..8a587a3c7ff 100644 --- a/addons/account/views/account_invoice_view.xml +++ b/addons/account/views/account_invoice_view.xml @@ -235,11 +235,11 @@
-
+
@@ -46,7 +46,7 @@
- +
@@ -57,57 +57,57 @@
- View + View
- New + New
- Reconciliation + Reconciliation
diff --git a/addons/account/views/account_payment_view.xml b/addons/account/views/account_payment_view.xml index f7a425f174b..9593f4207e3 100644 --- a/addons/account/views/account_payment_view.xml +++ b/addons/account/views/account_payment_view.xml @@ -57,7 +57,7 @@
- +
@@ -272,7 +272,7 @@