From 9d2e29795e9702d844e81d8d7ee04fff94ac274d Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 12 Jul 2011 11:54:59 +0200 Subject: [PATCH] [IMP] only compute invisible attrs/modifier in list view, as for non-editable lists we may be missing fields required to compute required and readonly and it's not like the list view needs those anyway: the handling of required and readonly in editable lists is performed solely by the form view embedded in each row, the list itself does not care at all bzr revid: xmo@openerp.com-20110712095459-l8hkm6d0vg1ynb07 --- addons/base/static/src/js/list.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/addons/base/static/src/js/list.js b/addons/base/static/src/js/list.js index 60d9e3b552c..c1df8857f08 100644 --- a/addons/base/static/src/js/list.js +++ b/addons/base/static/src/js/list.js @@ -256,11 +256,12 @@ openerp.base.ListView = openerp.base.View.extend( /** @lends openerp.base.ListVi if (column.modifiers) { var modifiers = JSON.parse(column.modifiers); column.modifiers_for = function (fields) { - var result = {}; - for (var modifier in modifiers) { - result[modifier] = domain_computer(modifiers[modifier], fields); + if (!modifiers.invisible) { + return {}; } - return result; + return { + 'invisible': domain_computer(modifiers.invisible, fields) + }; }; } else { column.modifiers_for = noop;