From 9cc67ea77b6105b32655cd43dfcadd4b1d26bfa9 Mon Sep 17 00:00:00 2001
From: jbm-odoo <jbm@odoo.com>
Date: Fri, 23 Aug 2019 08:13:38 +0000
Subject: [PATCH] [FIX] ir_ui_view: Inconsistent filters on m2o

Inconsistent filters on the product_id many2one fields.

We should never use a "search_default_*" on a many2one field,
because this will only apply in the Search More popup and not
on the auto-completion.
We should always use a domain, as it will apply in both cases.

id=1944237

closes odoo/odoo#36009

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/sale/wizard/sale_make_invoice_advance_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/sale/wizard/sale_make_invoice_advance_views.xml b/addons/sale/wizard/sale_make_invoice_advance_views.xml
index 03e7ebbff4d..ef79b39f440 100644
--- a/addons/sale/wizard/sale_make_invoice_advance_views.xml
+++ b/addons/sale/wizard/sale_make_invoice_advance_views.xml
@@ -20,7 +20,7 @@
                             <label for="deduct_down_payments"/>
                         </div>
                         <field name="product_id"
-                            context="{'search_default_services': 1, 'default_type': 'service', 'default_invoice_policy': 'order'}" class="oe_inline"
+                            context="{'default_invoice_policy': 'order'}" class="oe_inline"
                             invisible="1"/>
                         <label for="amount" attrs="{'invisible': [('advance_payment_method', 'not in', ('fixed','percentage'))]}"/>
                         <div attrs="{'invisible': [('advance_payment_method', 'not in', ('fixed','percentage'))]}">