From 9c5c3cce561ce25ff7e1fadfa9cb34ddda39969d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Wed, 29 Jun 2022 07:39:22 +0000
Subject: [PATCH] [FW][FIX] knowledge: correctly set rule permission

Correctly set write access rule to write (and create) instead of being global.
Read rule for internals and portal users is based on has_access field. Also
add some additional details in rules name to make their name explicit and
understand the rule purpose at a glance.

Task-2859616

X-original-commit: odoo/odoo@ba05b7a87c3aea7da75cbd003fba8b7a1905dbb3
Part-of: odoo/odoo#95471
---
 addons/knowledge/security/ir_rule.xml         | 1 +
 addons/website_knowledge/security/ir_rule.xml | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/addons/knowledge/security/ir_rule.xml b/addons/knowledge/security/ir_rule.xml
index 7ef8b749a9d..59cf66d460b 100644
--- a/addons/knowledge/security/ir_rule.xml
+++ b/addons/knowledge/security/ir_rule.xml
@@ -23,6 +23,7 @@
         <field name="model_id" ref="model_knowledge_article"/>
         <field name="domain_force">[('user_has_write_access', '=', True)]</field>
         <field name="groups" eval="[(4, ref('base.group_user'))]"/>
+        <field name="perm_read" eval="False"/>
     </record>
 
     <!-- ARTICLE MEMBER -->
diff --git a/addons/website_knowledge/security/ir_rule.xml b/addons/website_knowledge/security/ir_rule.xml
index 9492d69474f..1ea8e5f1d1a 100644
--- a/addons/website_knowledge/security/ir_rule.xml
+++ b/addons/website_knowledge/security/ir_rule.xml
@@ -2,7 +2,7 @@
 <odoo noupdate="1">
     <!-- ARTICLE -->
     <record id="rule_knowledge_article_users_read" model="ir.rule">
-        <field name="name">Articles: users/portal: published gives access</field>
+        <field name="name">Articles: users/portal: published gives read access</field>
         <field name="model_id" ref="knowledge.model_knowledge_article"/>
         <field name="perm_write" eval="False"/>
         <field name="perm_create" eval="False"/>
@@ -12,7 +12,7 @@
     </record>
 
     <record id="rule_knowledge_article_public_users_read" model="ir.rule">
-        <field name="name">Articles: public: published gives access</field>
+        <field name="name">Articles: public: published gives read access</field>
         <field name="model_id" ref="knowledge.model_knowledge_article"/>
         <field name="perm_write" eval="False"/>
         <field name="perm_create" eval="False"/>