From 9c5ae5432fc3bdd1ca89b27345e5834f2f0e15e6 Mon Sep 17 00:00:00 2001
From: dasz <dasz@odoo.com>
Date: Fri, 9 Jun 2023 11:10:35 +0000
Subject: [PATCH] [IMP] hr,hr_contract: UX changes

Add filters to hr.employee views

task-3356662
see odoo/enterprise#42177

closes odoo/odoo#124452

Signed-off-by: Kevin Baptiste <kba@odoo.com>
---
 addons/hr/views/hr_employee_public_views.xml   |  2 +-
 addons/hr/views/hr_employee_views.xml          |  2 ++
 addons/hr_contract/views/hr_employee_views.xml | 14 ++++++++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/addons/hr/views/hr_employee_public_views.xml b/addons/hr/views/hr_employee_public_views.xml
index d432d048a12..ef7df51cd3b 100644
--- a/addons/hr/views/hr_employee_public_views.xml
+++ b/addons/hr/views/hr_employee_public_views.xml
@@ -111,7 +111,7 @@
                     <field name="department_id"/>
                     <field name="job_title"/>
                     <field name="parent_id" widget="many2one_avatar_user"/>
-                    <field name="coach_id" invisible="1"/>
+                    <field name="coach_id" optional="show"/>
                 </tree>
             </field>
         </record>
diff --git a/addons/hr/views/hr_employee_views.xml b/addons/hr/views/hr_employee_views.xml
index 5137cb7c87d..d58af7979b4 100644
--- a/addons/hr/views/hr_employee_views.xml
+++ b/addons/hr/views/hr_employee_views.xml
@@ -14,6 +14,7 @@
                     </searchpanel>
                     <field name="parent_id" string="Manager"/>
                     <field name="job_id"/>
+                    <field name="coach_id"/>
                     <field name="category_ids" groups="hr.group_hr_user"/>
                     <field name="private_car_plate" />
                     <separator/>
@@ -34,6 +35,7 @@
                         <filter name="group_manager" string="Manager" domain="[]" context="{'group_by': 'parent_id'}"/>
                         <filter name="group_department" string="Department" domain="[]" context="{'group_by': 'department_id'}"/>
                         <filter name="group_job" string="Job" domain="[]" context="{'group_by': 'job_id'}"/>
+                        <filter name="group_start" string="Start Date" domain="[]" context="{'group_by': 'create_date'}"/>
                         <filter name="group_category_ids" string="Tags" domain="[]" context="{'group_by': 'category_ids'}"/>
                     </group>
                 </search>
diff --git a/addons/hr_contract/views/hr_employee_views.xml b/addons/hr_contract/views/hr_employee_views.xml
index 5be383ed5b4..643d13ffbcb 100644
--- a/addons/hr_contract/views/hr_employee_views.xml
+++ b/addons/hr_contract/views/hr_employee_views.xml
@@ -1,5 +1,19 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
+    <record id="hr_employee_view_search" model="ir.ui.view">
+        <field name="name">hr.employee.view.search.inherit.contract</field>
+        <field name="model">hr.employee</field>
+        <field name="inherit_id" ref="hr.view_employee_filter"/>
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='parent_id']" position="after">
+                <field name="first_contract_date"/>
+            </xpath>
+            <xpath expr="//filter[@name='group_start']" position="attributes">
+                <attribute name="context">{'group_by': 'first_contract_date'}</attribute>
+            </xpath>
+        </field>
+    </record>
+
     <record id="view_employee_tree" model="ir.ui.view">
         <field name="name">hr.employee.tree</field>
         <field name="model">hr.employee</field>