From 9c19db3e35084023960ac67f154be315b3ba5cb0 Mon Sep 17 00:00:00 2001
From: Dharmraj Jhala <dja@odoo.com>
Date: Fri, 24 Jan 2020 08:48:03 +0000
Subject: [PATCH] [FIX] mass_mailing: fix mass mailing creation in non debug
 mode

Purpose: make `name` a non-required field in form view

Currently `name` field in the mass mailing is visible only in the debug
mode, and is set via create method based on `subject`. If user tries to
create a new mass mailing object in non debug mode, it gives a warning.

This commit fixes the behavior by setting `name` field as non-required
in the form-view and thus avoiding the warning when field is not visible.
It will not cause issue since the `name` field is coming from the model
`utm.source` and is already a required through field definition.

Task 2178214
PR #43709

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/mass_mailing/views/mailing_mailing_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/mass_mailing/views/mailing_mailing_views.xml b/addons/mass_mailing/views/mailing_mailing_views.xml
index c6fc0a3dc29..577d71f07a4 100644
--- a/addons/mass_mailing/views/mailing_mailing_views.xml
+++ b/addons/mass_mailing/views/mailing_mailing_views.xml
@@ -196,7 +196,7 @@
                                 <group>
                                     <group>
                                         <field name="id" invisible="1"/>
-                                        <field name="name" attrs="{'required': [('id', '!=', False)]}" groups="base.group_no_one" string="Name"/>
+                                        <field name="name" required="False" groups="base.group_no_one" string="Name"/>
                                         <field name="user_id"/>
                                         <field name="email_from" attrs="{'readonly': [('state', 'in', ('sending', 'done'))]}"/>
                                         <label for="reply_to"/>