From 9bab1ed2afb92bad5bcc26762507275dec5bea9b Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Thu, 29 Nov 2018 12:27:50 +0100
Subject: [PATCH] [IMP] hr_payroll: Improve payslip creation/validation flow

Avoid to display the buttons on each stage (compute sheet, cancel, ...).

Now the next action is clear on the payslip.
---
 addons/hr_payroll/models/hr_payslip.py       | 2 +-
 addons/hr_payroll/views/hr_payslip_views.xml | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/hr_payroll/models/hr_payslip.py b/addons/hr_payroll/models/hr_payslip.py
index e8f549a6412..af1750a19c9 100644
--- a/addons/hr_payroll/models/hr_payslip.py
+++ b/addons/hr_payroll/models/hr_payslip.py
@@ -129,7 +129,7 @@ class HrPayslip(models.Model):
             contracts = payslip.contract_id or \
                 payslip.employee_id._get_contracts(payslip.date_from, payslip.date_to)
             lines = [(0, 0, line) for line in payslip._get_payslip_lines(contracts)]
-            payslip.write({'line_ids': lines, 'number': number})
+            payslip.write({'line_ids': lines, 'number': number, 'state': 'verify'})
         return True
 
     @api.model
diff --git a/addons/hr_payroll/views/hr_payslip_views.xml b/addons/hr_payroll/views/hr_payslip_views.xml
index 780f1af5fee..4ae92d55b42 100644
--- a/addons/hr_payroll/views/hr_payslip_views.xml
+++ b/addons/hr_payroll/views/hr_payslip_views.xml
@@ -128,12 +128,12 @@
         <field name="arch" type="xml">
             <form string="Payslip">
             <header>
-                <button string="Confirm" name="action_payslip_done" type="object" states="draft" class="oe_highlight"/>
+                <button string="Confirm" name="action_payslip_done" type="object" states="verify" class="oe_highlight"/>
                 <button string="Refund" name="refund_sheet" states="confirm,done" type='object' />
                 <button string="Set to Draft" name="action_payslip_draft" type="object" states="cancel"/>
                 <button string="Compute Sheet" name="compute_sheet" type="object" states="draft" class="oe_highlight"/>
-                <button string="Cancel Payslip" name="action_payslip_cancel" type="object" states="draft,hr_check,confirm,verify"/>
-                <field name="state" widget="statusbar" statusbar_visible="draft,confirm"/>
+                <button string="Cancel Payslip" name="action_payslip_cancel" type="object" states="draft,confirm,verify"/>
+                <field name="state" widget="statusbar" statusbar_visible="draft,verify,confirm"/>
             </header>
             <sheet>
                 <div class="oe_button_box" name="button_box">