From 9b36d9ba73bbe8505b0eb078aa742bf25f2099be Mon Sep 17 00:00:00 2001
From: "Vir (Open ERP)" <vir@tinyerp.com>
Date: Fri, 3 Sep 2010 11:47:18 +0530
Subject: [PATCH] [IMP] Usability Improvements in extended group

bzr revid: vir@tinyerp.com-20100903061718-h0jptgsymym4w2sk
---
 addons/account/partner_view.xml            |  4 ++--
 addons/base_setup/base_setup_installer.xml |  2 +-
 addons/base_setup/base_setup_todo.xml      |  8 ++++----
 addons/base_setup/installer.py             | 12 ++++++++++++
 addons/crm/crm_installer_view.xml          |  1 +
 addons/crm/crm_opportunity_menu.xml        |  1 +
 addons/crm/crm_opportunity_view.xml        |  2 +-
 addons/hr/hr_department_view.xml           |  2 +-
 addons/hr/hr_installer.xml                 |  4 ++--
 addons/hr/hr_view.xml                      | 11 +++++------
 addons/mrp/mrp_view.xml                    |  3 ++-
 addons/project/project_installer.xml       |  4 ++--
 addons/sale/sale_view.xml                  |  8 ++++----
 addons/stock/stock_view.xml                |  4 ++--
 14 files changed, 40 insertions(+), 26 deletions(-)

diff --git a/addons/account/partner_view.xml b/addons/account/partner_view.xml
index 7f3c344ebff..2b5fc927dff 100644
--- a/addons/account/partner_view.xml
+++ b/addons/account/partner_view.xml
@@ -76,13 +76,13 @@
                 <page string="Accounting">
                     <group col="2" colspan="2">
                         <separator string="Customer Accounting Properties" colspan="2"/>
-                        <field name="property_account_receivable" groups="account.group_account_user" />
+                        <field name="property_account_receivable" groups="base.group_extended" />
                         <field name="property_account_position" widget="selection"/>
                         <field name="property_payment_term" widget="selection"/>
                     </group>
                     <group col="2" colspan="2">
                         <separator string="Supplier Accounting Properties" colspan="2"/>
-                        <field name="property_account_payable" groups="account.group_account_user"/>
+                        <field name="property_account_payable" groups="base.group_extended"/>
                     </group>
                     <group col="2" colspan="2">
                         <separator string="Customer Credit" colspan="2"/>
diff --git a/addons/base_setup/base_setup_installer.xml b/addons/base_setup/base_setup_installer.xml
index cdaf66100ac..ceeebd2e8eb 100644
--- a/addons/base_setup/base_setup_installer.xml
+++ b/addons/base_setup/base_setup_installer.xml
@@ -28,7 +28,7 @@
             <field name="stock" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/> <field name="mrp" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
             <field name="account" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/> <field name="purchase" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
             <field name="hr" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/> <field name="point_of_sale" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
-            <field name="marketing" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/> <field name="misc_tools" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
+            <field name="marketing" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)" groups="base.group_extended"/> <field name="misc_tools" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
             <field name="report_designer" groups="base.group_extended" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
             <separator string="Install Specific Business Modules" colspan="4"/>
             <field name="association" on_change="onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account,purchase,hr,point_of_sale,marketing,misc_tools,report_designer,association,auction)"/>
diff --git a/addons/base_setup/base_setup_todo.xml b/addons/base_setup/base_setup_todo.xml
index a4b4b2bda23..59543200076 100644
--- a/addons/base_setup/base_setup_todo.xml
+++ b/addons/base_setup/base_setup_todo.xml
@@ -36,10 +36,10 @@
                     <field name="currency" widget="selection"/>
                 </group>
                 <newline/>
-                <group colspan="2" groups="base.group_extended" >
-                    <field name="rml_header1" colspan="5" invisible="1"/>
-                    <field name="rml_footer1" colspan="5" invisible="1"/>
-                    <field name="rml_footer2" colspan="5" invisible="1"/>
+                <group colspan="2">
+                    <field name="rml_header1" colspan="5" invisible="1" groups="base.group_extended"/>
+                    <field name="rml_footer1" colspan="5" invisible="1" groups="base.group_extended"/>
+                    <field name="rml_footer2" colspan="5" invisible="1" groups="base.group_extended"/>
 
                     <separator colspan="4"
                                string="Your Logo - Use a size of about 450x150 pixels."/>
diff --git a/addons/base_setup/installer.py b/addons/base_setup/installer.py
index 2886857a45d..edfbb573911 100644
--- a/addons/base_setup/installer.py
+++ b/addons/base_setup/installer.py
@@ -104,6 +104,18 @@ class base_setup_installer(osv.osv_memory):
             return ['document_ftp']
         return None
 
+    def _if_misc_tools(self, cr, uid, ids, context=None):
+        interface = self.pool.get('res.users').browse(cr, uid, uid, context=context).view
+        if interface == 'simple' or interface =='extended' :
+            return ['lunch','idea','survey']
+        return None
+
+    def _if_account(self, cr, uid, ids, context=None):
+        if self.pool.get('res.users').browse(cr, uid, uid, context=context)\
+               .view == 'simple':
+            return ['account_voucher']
+        return None
+
     def onchange_moduleselection(self, cr, uid, ids, *args):
         closed, total = self.get_current_progress(cr, uid)
 
diff --git a/addons/crm/crm_installer_view.xml b/addons/crm/crm_installer_view.xml
index 0b5b87ff485..855e2a6a125 100644
--- a/addons/crm/crm_installer_view.xml
+++ b/addons/crm/crm_installer_view.xml
@@ -61,6 +61,7 @@
     <record id="crm_installer_todo" model="ir.actions.todo">
       <field name="action_id" ref="action_crm_installer"/>
       <field name="sequence">3</field>
+      <field eval="[(6,0,[ref('base.group_extended')])]" name="groups_id"/>
     </record>
   </data>
 </openerp>
diff --git a/addons/crm/crm_opportunity_menu.xml b/addons/crm/crm_opportunity_menu.xml
index 282dc78bb8c..0bfb5f35efc 100644
--- a/addons/crm/crm_opportunity_menu.xml
+++ b/addons/crm/crm_opportunity_menu.xml
@@ -5,6 +5,7 @@
      <act_window
             id="act_crm_opportunity_crm_phonecall_new"
             name="Phone calls"
+            groups="base.group_extended"
             res_model="crm.phonecall"
             src_model="crm.lead"
             view_mode="tree,calendar,form"
diff --git a/addons/crm/crm_opportunity_view.xml b/addons/crm/crm_opportunity_view.xml
index 93768a7a0aa..f67ad93e134 100644
--- a/addons/crm/crm_opportunity_view.xml
+++ b/addons/crm/crm_opportunity_view.xml
@@ -31,7 +31,7 @@
                             <field name="probability"/>
                             <field name="date_deadline" string="Expected Closing"/>
                             <button string="Schedule/Log Call"
-                            name="%(opportunity2phonecall_act)d" icon="terp-call-start" type="action"  />
+                            name="%(opportunity2phonecall_act)d" icon="terp-call-start" type="action" groups="base.group_extended"/>
                             <newline/>
                             <field name="date_action"/>
                             <field name="title_action"/>
diff --git a/addons/hr/hr_department_view.xml b/addons/hr/hr_department_view.xml
index c2bb6ac7390..d1e6f2e8d52 100644
--- a/addons/hr/hr_department_view.xml
+++ b/addons/hr/hr_department_view.xml
@@ -76,7 +76,7 @@
         </record>
 
        <menuitem action="open_module_tree_department" id="menu_department_def" parent="hr.menu_department_tree"/>
-       <menuitem action="open_module_tree_department" id="menu_hr_department_tree" parent="hr.menu_hr_management" sequence="6"/>
+       <menuitem action="open_module_tree_department" id="menu_hr_department_tree" parent="hr.menu_hr_management" sequence="6" groups="base.group_extended"/>
 
         <record model="ir.ui.view" id="view_users_form_inherit">
             <field name="name">res.users.form</field>
diff --git a/addons/hr/hr_installer.xml b/addons/hr/hr_installer.xml
index 934f5889ab3..a10393aac33 100644
--- a/addons/hr/hr_installer.xml
+++ b/addons/hr/hr_installer.xml
@@ -29,8 +29,8 @@
             <field name="hr_contract"/>
             <field name="hr_evaluation"/>
             <field name="hr_attendance"/>
-            <field name="hr_payroll"/>
-            <field name="hr_payroll_account"/>
+            <field name="hr_payroll" groups="base.group_extended"/>
+            <field name="hr_payroll_account" groups="base.group_extended"/>
           </group>
           <xpath expr="//button[@string='Install Modules']" position="attributes">
               <attribute name="string">Configure</attribute>
diff --git a/addons/hr/hr_view.xml b/addons/hr/hr_view.xml
index 659ddfa36e9..250f47b2055 100644
--- a/addons/hr/hr_view.xml
+++ b/addons/hr/hr_view.xml
@@ -102,7 +102,7 @@
                     <separator orientation="vertical" />
                     <field name="name"/>
                     <field name="department_id" widget="selection">
-                    <filter icon="terp-personal+" domain="[('department_id','=',context.get('department_id',False))]" help="My Departments Employee"/>
+                    <filter icon="terp-personal+" domain="[('department_id','=',context.get('department_id',False))]" string="My Departments Employee"/>
                     </field>
                     <field name="job_id" widget="selection"/>
                     <field name="parent_id"/>
@@ -189,7 +189,7 @@
         </record>
 
         <menuitem action="action_hr_marital_status" id="hr_menu_marital_status"
-            parent="hr.menu_view_employee_category_configuration_form" sequence="3"/>
+            parent="hr.menu_view_employee_category_configuration_form" sequence="3" groups="base.group_extended"/>
 
         <!--
         =======================
@@ -320,7 +320,6 @@
                     <group col="6" colspan="4">
                     <field name="name" />
                     <field name="department_id" />
-                    <newline/>
                     <field name="company_id" widget="selection" groups="base.group_multi_company"/>
                     <field name="expected_employees"/>
                     <field name="no_of_employee"/>
@@ -355,6 +354,7 @@
                 <tree string="Job">
                     <field name="name" />
                     <field name="department_id" />
+                    <field name="company_id" groups="base.group_multi_company"/>
                     <field name="expected_employees"/>
                     <field name="no_of_employee"/>
                     <field name="state"/>
@@ -370,10 +370,8 @@
                 <search string="Jobs">
                     <filter icon="terp-check" domain="[('state','in',('open','recruit'))]" string="Current"
                         name="Current" help="Open and in recruitment positions"/>
-                    <filter icon="terp-camera_test" domain="[('state','=','open')]" string="Open"
-                        help="Open Positions"/>
                     <separator orientation="vertical"/>
-                    <filter icon="terp-personal+"  domain="[('state','=','recruit')]" string="Recruitment"
+                    <filter icon="terp-personal+"  domain="[('state','=','recruit')]" string="In Recruitment"
                         help="In Recruitment"/>
                     <separator orientation="vertical"/>
                     <field name="name"/>
@@ -383,6 +381,7 @@
                     <newline />
                     <group expand="0" string="Group By...">
                     <filter string="Department" icon="terp-personal+" domain="[]" context="{'group_by':'department_id'}"/>
+                    <filter string="Company" icon="terp-go-home" domain="[]" context="{'group_by':'company_id'}"  groups="base.group_multi_company"/>
                     </group>
                 </search>
              </field>
diff --git a/addons/mrp/mrp_view.xml b/addons/mrp/mrp_view.xml
index 058cc99a7b6..5d47c8acf0c 100644
--- a/addons/mrp/mrp_view.xml
+++ b/addons/mrp/mrp_view.xml
@@ -901,7 +901,8 @@
             view_type="tree"
             view_id="mrp_bom_tree_view"
             res_model="mrp.bom"
-            src_model="product.product"/>
+            src_model="product.product"
+            groups="base.group_extended"/>
 
         <act_window
             domain="[('product_id', '=', active_id),('bom_id','=',False)]"
diff --git a/addons/project/project_installer.xml b/addons/project/project_installer.xml
index 947171d4c0a..56064158683 100644
--- a/addons/project/project_installer.xml
+++ b/addons/project/project_installer.xml
@@ -26,13 +26,13 @@
           <group colspan="8">
             <field name="project_crm"/>
             <field name="project_long_term" groups="base.group_extended"/>
-            <field name="project_wiki"/>
+            <field name="project_wiki" groups="base.group_extended"/>
             <field name="hr_timesheet_sheet"/>
             <field name="hr_timesheet_invoice"/>
             <field name="account_budget" groups="base.group_extended"/>
             <field name="project_messages" groups="base.group_extended"/>
             <separator string="Methodologies" colspan="4"/>
-            <field name="scrum"/>
+            <field name="scrum" groups="base.group_extended"/>
             <field name="project_gtd"/>
           </group>
         </data>
diff --git a/addons/sale/sale_view.xml b/addons/sale/sale_view.xml
index 9279a946ff9..6f21e925e1a 100644
--- a/addons/sale/sale_view.xml
+++ b/addons/sale/sale_view.xml
@@ -111,8 +111,8 @@
                         <page string="Sale Order">
                             <field name="partner_id" on_change="onchange_partner_id(partner_id)" required="1"/>
                             <field domain="[('partner_id','=',partner_id)]" name="partner_order_id"/>
-                            <field domain="[('partner_id','=',partner_id)]" name="partner_invoice_id"/>
-                            <field domain="[('partner_id','=',partner_id)]" name="partner_shipping_id"/>
+                            <field domain="[('partner_id','=',partner_id)]" name="partner_invoice_id" groups="base.group_extended"/>
+                            <field domain="[('partner_id','=',partner_id)]" name="partner_shipping_id" groups="base.group_extended"/>
                             <field domain="[('type','=','sale')]" name="pricelist_id" groups="base.group_extended"/>
                             <field name="project_id"
                                 context="{'partner_id':partner_id, 'contact_id':partner_order_id, 'pricelist_id':pricelist_id, 'default_name':name}"
@@ -387,13 +387,13 @@ to your configuration: from the sale order, from the pickings, etc.
                             <field name="invoiced"/>
                             <field name="company_id" groups="base.group_multi_company" readonly="1"/>
                             <separator colspan="4" string="Manual Designation"/>
-                            <field colspan="4" name="name"/>
+                            <field colspan="4" name="name" groups="base.group_extended"/>
                             <field name="price_unit"/>
                             <field name="discount"/>
                             <field name="type" groups="base.group_extended"/>
                             <field name="delay" groups="base.group_extended"/>
                             <field name="price_subtotal"/>
-                            <field name="th_weight"/>
+                            <field name="th_weight" groups="base.group_extended"/>
                             <separator colspan="4" string="Taxes"/>
                             <field colspan="4" name="tax_id" domain="[('parent_id','=',False),('type_tax_use','&lt;&gt;','purchase')]" nolabel="1"/>
                             <separator colspan="4" string="States"/>
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index f81de1c5faf..203b190053c 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -3,7 +3,7 @@
     <data>
 
         <menuitem icon="terp-stock" id="menu_stock_root" name="Warehouse" sequence="5"/>
-        <menuitem id="menu_stock_warehouse_mgmt" name="Warehouse Management" parent="menu_stock_root" sequence="1"/>
+        <menuitem id="menu_stock_warehouse_mgmt" name="Warehouse Management" parent="menu_stock_root" sequence="1" groups="base.group_extended"/>
         <menuitem id="menu_stock_products_moves" name="Products Moves" parent="menu_stock_root" sequence="2"/>
         <menuitem id="menu_stock_product" name="Product" parent="menu_stock_root" sequence="6"/>
         <menuitem action="product.product_normal_action" id="menu_stock_products_menu" parent="menu_stock_product" sequence="1"/>
@@ -1523,7 +1523,7 @@
                     <button name="%(stock.move_scrap)d"
                         string="Scrap Products" type="action"
                         icon="gtk-convert" context="{'scrap': True}"
-                        states="draft,waiting,confirmed,assigned" />
+                        states="draft,waiting,confirmed,assigned" groups="base.group_extended"/>
                     <field name="prodlot_id" groups="base.group_extended"/>
                     <button name="%(track_line)d" string="Split in production lots" type="action"
                         icon="terp-stock_effects-object-colorize" attrs="{'invisible': [('prodlot_id','&lt;&gt;',False)]}"