From 9979c52ac63e650f80a4cc9e9f1004be461f99e5 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Thu, 31 Mar 2011 10:03:35 +0200
Subject: [PATCH] [FIX] warnings

bzr revid: xmo@openerp.com-20110331080335-u3vxmxr2cn7vx3nf
---
 addons/base/static/src/js/data.js   | 13 +++++++++----
 addons/base/static/src/js/form.js   |  2 +-
 addons/base/static/src/js/search.js | 11 +++++------
 addons/base/static/src/js/views.js  |  2 +-
 4 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/addons/base/static/src/js/data.js b/addons/base/static/src/js/data.js
index d294ca8d8b9..60c4effaaee 100644
--- a/addons/base/static/src/js/data.js
+++ b/addons/base/static/src/js/data.js
@@ -1,18 +1,23 @@
 
 openerp.base.data = function(openerp) {
 
-openerp.base.DataGroup =  openerp.base.Controller.extend({
+openerp.base.DataGroup =  openerp.base.Controller.extend(
+    /** @lends openep.base.DataGroup# */{
     /**
      * Management interface between views and the collection of selected OpenERP
      * records (represents the view's state?)
+     *
+     * @constructs
+     * @extends openerp.base.Controller
+     * @param {openerp.base.Session} session Current OpenERP session
      */
     init: function(session) {
         this._super(session, null);
-    },
+    }
 });
 
-openerp.base.DataSet =  openerp.base.Controller.extend( /** @lends openerp.base.DataSet# */{
-
+openerp.base.DataSet =  openerp.base.Controller.extend(
+    /** @lends openerp.base.DataSet# */{
     /**
      * Management interface between views and the collection of selected
      * OpenERP records (represents the view's state?)
diff --git a/addons/base/static/src/js/form.js b/addons/base/static/src/js/form.js
index 4d379d814f2..87cac14a0e8 100644
--- a/addons/base/static/src/js/form.js
+++ b/addons/base/static/src/js/form.js
@@ -446,7 +446,7 @@ openerp.base.FieldBoolean = openerp.base.Field.extend({
         this.$element.find('input')[0].checked = value;
     },
     get_value: function() {
-        this.$element.find('input')[0].checked;
+        return this.$element.find('input').is(':checked');
     }
 });
 
diff --git a/addons/base/static/src/js/search.js b/addons/base/static/src/js/search.js
index e40f96e8996..c6523bef7e0 100644
--- a/addons/base/static/src/js/search.js
+++ b/addons/base/static/src/js/search.js
@@ -518,10 +518,10 @@ openerp.base.search.ExtendedSearchProposition = openerp.base.BaseWidget.extend({
         var extended_filters_types = openerp.base.search.extended_filters_types;
         type = type in extended_filters_types ? type : "char";
         _.each(extended_filters_types[type].operators, function(operator) {
-            option = jQuery('<option/>');
-            option.attr('value', operator.value);
-            option.text(operator.text);
-            option.appendTo(_this.$element.find('.searchview_extended_prop_op'));
+            var option = jQuery('<option/>')
+                .attr('value', operator.value)
+                .text(operator.text)
+                .appendTo(_this.$element.find('.searchview_extended_prop_op'));
         });
         this.value_component = extended_filters_types[type].build_component(this);
         var render = this.value_component.render({});
@@ -543,8 +543,7 @@ openerp.base.search.ExtendedSearchProposition.Char = openerp.base.BaseWidget.ext
     identifier_prefix: 'extended-search-proposition-char',
     
     get_value: function() {
-        var val = this.$element.val();
-        return val;
+        return this.$element.val();
     }
 });
 
diff --git a/addons/base/static/src/js/views.js b/addons/base/static/src/js/views.js
index 8654239b450..b0b79c3e5f7 100644
--- a/addons/base/static/src/js/views.js
+++ b/addons/base/static/src/js/views.js
@@ -184,7 +184,7 @@ openerp.base.BaseWidget = openerp.base.Controller.extend({
      */
     start: function () {
         this._super();
-        var tmp = document.getElementById(this.element_id)
+        var tmp = document.getElementById(this.element_id);
         this.$element = tmp ? $(tmp) : null;
     },
     /**