From 98e66766213be19a94c09b7fb7d2c3b096b5df6b Mon Sep 17 00:00:00 2001
From: Haresh Shyara <hsh@odoo.com>
Date: Fri, 4 Aug 2017 15:05:23 +0200
Subject: [PATCH] [IMP] base,l10n_cr,l10n_do: avoid title clashes in
 localizations

Seen that:
- a unicity constraint on a translated field may lead to unexpected results
- declaring records with xmlids of other modules (aka 'base') raises a warning
- some titles may be translated and are highly local

=> we let people manage titles of their countries, even if it may lead
   to a few duplicates in case where more than 1 localization is installed
---
 addons/l10n_cr/data/l10n_cr_state_data.xml | 26 +++++++++++-----------
 addons/l10n_do/data/l10n_do_state_data.xml | 12 +++++-----
 odoo/addons/base/res/res_partner.py        |  1 -
 3 files changed, 19 insertions(+), 20 deletions(-)

diff --git a/addons/l10n_cr/data/l10n_cr_state_data.xml b/addons/l10n_cr/data/l10n_cr_state_data.xml
index 3c523f44634..585012600b2 100644
--- a/addons/l10n_cr/data/l10n_cr_state_data.xml
+++ b/addons/l10n_cr/data/l10n_cr_state_data.xml
@@ -43,55 +43,55 @@
         Resource: res.partner.title
         Update partner titles
         -->
-        <record id="base.res_partner_title_pvt_ltd" model="res.partner.title">
+        <record id="res_partner_title_pvt_ltd" model="res.partner.title">
             <field name="name">Corporation</field>
             <field name="shortcut">Corp.</field>
         </record>
-        <record id="base.res_partner_title_ltd" model="res.partner.title">
+        <record id="res_partner_title_ltd" model="res.partner.title">
             <field name="name">Limited Company</field>
             <field name="shortcut">Ltd.</field>
         </record>
-        <record id="base.res_partner_title_sal" model="res.partner.title">
+        <record id="res_partner_title_sal" model="res.partner.title">
             <field name="name">Sociedad An&#243;nima Laboral</field>
             <field name="shortcut">S.A.L.</field>
         </record>
-        <record id="base.res_partner_title_asoc" model="res.partner.title">
+        <record id="res_partner_title_asoc" model="res.partner.title">
             <field name="name">Asociation</field>
             <field name="shortcut">Asoc.</field>
         </record>
-        <record id="base.res_partner_title_gov" model="res.partner.title">
+        <record id="res_partner_title_gov" model="res.partner.title">
             <field name="name">Government</field>
             <field name="shortcut">Gov.</field>
         </record>
-        <record id="base.res_partner_title_edu" model="res.partner.title">
+        <record id="res_partner_title_edu" model="res.partner.title">
             <field name="name">Educational Institution</field>
             <field name="shortcut">Edu.</field>
         </record>
-        <record id="base.res_partner_title_indprof" model="res.partner.title">
+        <record id="res_partner_title_indprof" model="res.partner.title">
             <field name="name">Independant Professional</field>
             <field name="shortcut">Ind. Prof.</field>
         </record>
-        <record id="base.res_partner_title_dra" model="res.partner.title">
+        <record id="res_partner_title_dra" model="res.partner.title">
             <field name="name">Doctora</field>
             <field name="shortcut">Dra.</field>
         </record>
-        <record id="base.res_partner_title_msc" model="res.partner.title">
+        <record id="res_partner_title_msc" model="res.partner.title">
             <field name="name">Msc.</field>
             <field name="shortcut">Msc.</field>
         </record>
-        <record id="base.res_partner_title_mba" model="res.partner.title">
+        <record id="res_partner_title_mba" model="res.partner.title">
             <field name="name">MBA</field>
             <field name="shortcut">MBA</field>
         </record>
-        <record id="base.res_partner_title_lic" model="res.partner.title">
+        <record id="res_partner_title_lic" model="res.partner.title">
             <field name="name">Licenciado</field>
             <field name="shortcut">Lic.</field>
         </record>
-        <record id="base.res_partner_title_licda" model="res.partner.title">
+        <record id="res_partner_title_licda" model="res.partner.title">
             <field name="name">Licenciada</field>
             <field name="shortcut">Licda.</field>
         </record>
-        <record id="base.res_partner_title_ing" model="res.partner.title">
+        <record id="res_partner_title_ing" model="res.partner.title">
             <field name="name">Ingeniero/a</field>
             <field name="shortcut">Ing.</field>
         </record>
diff --git a/addons/l10n_do/data/l10n_do_state_data.xml b/addons/l10n_do/data/l10n_do_state_data.xml
index 322e27b3b4c..8191da21cd9 100644
--- a/addons/l10n_do/data/l10n_do_state_data.xml
+++ b/addons/l10n_do/data/l10n_do_state_data.xml
@@ -172,27 +172,27 @@
     Resource: res.partner.title
     Update partner titles
     -->
-        <record id="base.res_partner_title_dra" model="res.partner.title">
+        <record id="res_partner_title_dra" model="res.partner.title">
             <field name="name">Doctora</field>
             <field name="shortcut">Dra.</field>
         </record>
-        <record id="base.res_partner_title_msc" model="res.partner.title">
+        <record id="res_partner_title_msc" model="res.partner.title">
             <field name="name">Msc.</field>
             <field name="shortcut">Msc.</field>
         </record>
-        <record id="base.res_partner_title_mba" model="res.partner.title">
+        <record id="res_partner_title_mba" model="res.partner.title">
             <field name="name">MBA</field>
             <field name="shortcut">MBA</field>
         </record>
-        <record id="base.res_partner_title_lic" model="res.partner.title">
+        <record id="res_partner_title_lic" model="res.partner.title">
             <field name="name">Licenciado</field>
             <field name="shortcut">Lic.</field>
         </record>
-        <record id="base.res_partner_title_licda" model="res.partner.title">
+        <record id="res_partner_title_licda" model="res.partner.title">
             <field name="name">Licenciada</field>
             <field name="shortcut">Licda.</field>
         </record>
-        <record id="base.res_partner_title_ing" model="res.partner.title">
+        <record id="res_partner_title_ing" model="res.partner.title">
             <field name="name">Ingeniero/a</field>
             <field name="shortcut">Ing.</field>
         </record>
diff --git a/odoo/addons/base/res/res_partner.py b/odoo/addons/base/res/res_partner.py
index 5b73d6848cd..7784cc231e6 100644
--- a/odoo/addons/base/res/res_partner.py
+++ b/odoo/addons/base/res/res_partner.py
@@ -124,7 +124,6 @@ class PartnerTitle(models.Model):
     name = fields.Char(string='Title', required=True, translate=True)
     shortcut = fields.Char(string='Abbreviation', translate=True)
 
-    _sql_constraints = [('name_uniq', 'unique (name)', "Title name already exists !")]
 
 class Partner(models.Model):
     _description = 'Contact'