From 98161fc61ab4667d0333975b2639547ec8a031fd Mon Sep 17 00:00:00 2001 From: Benjamin Vray Date: Thu, 2 Apr 2020 12:46:17 +0000 Subject: [PATCH] [FIX] web_editor: fix updateui method replace the "return" with "continue". What should have been done when the loop that was originally a "foreach" became a "for" loop. closes odoo/odoo#48919 X-original-commit: 8af8e6ddb2be9a0c57356d075e092b8da42662f0 Signed-off-by: Quentin Smetz (qsm) --- addons/web_editor/static/src/js/editor/snippets.options.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index 235cb0a8d17..71504e2a959 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -1738,14 +1738,14 @@ const SnippetOptionWidget = Widget.extend({ if (params.applyTo) { const $firstSubTarget = this.$(params.applyTo).eq(0); if (!$firstSubTarget.length) { - return; + continue; } obj = createPropertyProxy(this, '$target', $firstSubTarget); } const value = await this._computeWidgetState.call(obj, methodName, params); if (value === undefined) { - return; + continue; } const normalizedValue = this._normalizeWidgetValue(value); widget.setValue(normalizedValue, methodName);