From 9776ff0bd29ec5e6e2a319b098fed865e9f4cbc8 Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Thu, 15 Dec 2022 16:14:41 +0000 Subject: [PATCH] [FIX] web_editor: review two pairs of shape junctions As the previous commit explained, there is sometimes a gap between two shapes due to some browser rounding errors, especially when using browser zoom. However, there are also some things we can do in our shapes themselves to decrease this problem. This commit fixes two pairs of shapes which were easily fixed by reviewing the rounding of one path and making the viewBox a square (making a viewBox a square is known to solve issues). However: - The first pair is not entirely fixed, the error is just reduced. - The second pair is fixed... but the shapes actually do not join very well (somehow the linear gradients do not seem to join properly)... but still better than a white line between the two. Reminder: several commits had attempted to fix this before ([1], [2], [3], [4]) (and this commit's parent). But that wasn't enough to stop it happening. Some shapes still need to be fixed although that will likely be done in future versions. [1]: https://github.com/odoo/odoo/commit/c0f62593a4da37e8404dddc0a5762879a5ebbf7f [2]: https://github.com/odoo/odoo/commit/ac82407b259eab929486bf0a333a48bc507efa60 [3]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566 [4]: https://github.com/odoo/odoo/commit/e386f318f5cff50901dba3db8a2587911ba02a6e task-2824607 opw-3069213 opw-3057533 closes odoo/odoo#108228 X-original-commit: 52e5afaa10ca7f2b3183bf6359b42929a9b3704a Signed-off-by: Quentin Smetz (qsm) --- addons/web_editor/static/shapes/Blocks/01_001.svg | 2 +- addons/web_editor/static/shapes/Blocks/02_001.svg | 2 +- addons/web_editor/static/shapes/Rainy/01.svg | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/web_editor/static/shapes/Blocks/01_001.svg b/addons/web_editor/static/shapes/Blocks/01_001.svg index a5c6fbb5999..37aae259939 100644 --- a/addons/web_editor/static/shapes/Blocks/01_001.svg +++ b/addons/web_editor/static/shapes/Blocks/01_001.svg @@ -1,7 +1,7 @@ + viewBox="0 0 1400 1400" xml:space="preserve">