From 9733bdfdc0959ddaaa53e0e870d1e7e901d670d8 Mon Sep 17 00:00:00 2001 From: Samuel Degueldre Date: Mon, 7 Sep 2020 11:22:45 +0000 Subject: [PATCH] [FIX] web_editor: do not display quality options on SVGs/GIFs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When the width and quality option for images was moved from the optimize-dialog to the left-panel, it was made available on all image types. However, width and quality options don't make sense on SVGs and would break animated gifs. This commit makes it so that quality options are only available on JPEG and PNG images. closes odoo/odoo#57564 X-original-commit: 315be6f4765268eada4b39a637136c86a30720eb Signed-off-by: Jérémy Kersten (jke) --- addons/web_editor/static/src/js/editor/snippets.options.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index 5b7aba79184..8e236bb93d1 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -3109,7 +3109,11 @@ const ImageHandlerOption = SnippetOptionWidget.extend({ * @override */ _computeVisibility() { - const src = this._getImg().getAttribute('src'); + const img = this._getImg(); + if (!['image/jpeg', 'image/png'].includes(img.dataset.mimetype)) { + return false; + } + const src = img.getAttribute('src'); return src && src !== '/'; }, /**