From 96c11f3e9c131ddfcb03ab4417c260d6ea473a9b Mon Sep 17 00:00:00 2001
From: "Xavier Bol (xbo)" <xbo@odoo.com>
Date: Thu, 4 May 2023 07:09:43 +0000
Subject: [PATCH] [FIX] project: avoid autofocus the state field

Before this commit, when the user goes to the form view of a task
and when to add a subtask into it. When he clicks on `Add a line`
on the subtree view of subtasks the state field is focused because
it is the first field focusable in that list view.

This commit removes the state field in focusable elements to directly
focus the next focusable element who is the name field.

task-3248592

Part-of: odoo/odoo#120508
---
 .../project_task_state_selection.xml                 | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/addons/project/static/src/components/project_task_state_selection/project_task_state_selection.xml b/addons/project/static/src/components/project_task_state_selection/project_task_state_selection.xml
index e901287eba5..300c4e78559 100644
--- a/addons/project/static/src/components/project_task_state_selection/project_task_state_selection.xml
+++ b/addons/project/static/src/components/project_task_state_selection/project_task_state_selection.xml
@@ -1,6 +1,9 @@
 <templates>
     <t t-name="project.ProjectTaskStateSelection" t-inherit="web.StateSelectionField" t-inherit-mode="primary" owl="1">
         <!-- Readonly button -->
+        <xpath expr="//t[@t-if='props.readonly']/button" position="attributes">
+            <attribute name="tabindex">-1</attribute>
+        </xpath>
         <xpath expr="//t[@t-if='props.readonly']/button/span[1]" position="attributes">
             <attribute name="t-attf-class">{{ stateIcon(currentValue) }} {{ statusColor(currentValue) }}</attribute>
         </xpath>
@@ -15,10 +18,15 @@
         <!-- The toggle mark as done button -->
         <xpath expr="//t[@t-if='props.readonly']" position="after">
             <t t-elif="isToggleMode and currentValue == '01_in_progress'">
-                <button t-if="isView(['kanban', 'list']) or this.env.isSmall" class="d-flex align-items-center btn fw-normal p-0" t-on-click.stop="toggleState" t-att-class="{'o_task_state_list_view': isView(['list'])}">
+                <button t-if="isView(['kanban', 'list']) or this.env.isSmall"
+                        class="d-flex align-items-center btn fw-normal p-0"
+                        tabindex="-1"
+                        t-att-class="{'o_task_state_list_view': isView(['list'])}"
+                        t-on-click.stop="toggleState"
+                >
                     <i t-attf-class="{{ stateIcon(currentValue) }} {{ statusColor(currentValue) }} {{ ['1_done', '1_canceled'].includes(currentValue) and isView(['kanban']) ? 'opacity-50' : '' }}"></i>
                 </button>
-                <button t-else="" class="o_state_button btn oe_highlight rounded-pill" style="white-space: nowrap;"
+                <button t-else="" class="o_state_button btn oe_highlight rounded-pill" style="white-space: nowrap;" tabindex="-1"
                     t-att-class="currentValue == '1_done' ? 'btn-success' : 'btn-light border-2 border-dark'"
                     t-on-click="toggleState" t-on-mouseenter="onMouseEnterStateButton"
                     t-on-mouseleave="onMouseLeaveStateButton">