From 96753cc37187d893acbfdf592aff3e7fd8d795a4 Mon Sep 17 00:00:00 2001
From: "Walid HANNICHE (waha)" <waha@odoo.com>
Date: Mon, 12 Dec 2022 17:44:39 +0000
Subject: [PATCH] [FIX] l10n_gcc_invoice: arabic invoice product name is
 displayed twice

Steps to reproduce:
-install l10n_sa_invoice module
-switch to a company in Saudi Arabia (SA company)
-create and print an invoice with a product that has arabic translation

Bug:
When adding a product and the Arabic translation.
If we add an internal reference it is added to the template,
Odoo directly concatenates this with the product name.
The result is the product name being duplicated.

Fix:
display line name and add the translation if it's different

opw-2829934

closes odoo/odoo#107798

X-original-commit: ad585bc41f49d047c150ceb9dc88bd9859fa046b
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
---
 .../l10n_gcc_invoice/views/report_invoice.xml | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/addons/l10n_gcc_invoice/views/report_invoice.xml b/addons/l10n_gcc_invoice/views/report_invoice.xml
index eb958b59398..af5f803f8f7 100644
--- a/addons/l10n_gcc_invoice/views/report_invoice.xml
+++ b/addons/l10n_gcc_invoice/views/report_invoice.xml
@@ -274,17 +274,26 @@
                             <tr t-att-class="'bg-200 fw-bold o_line_section' if line.display_type == 'line_section' else 'fst-italic o_line_note' if line.display_type == 'line_note' else ''">
                                 <t t-if="line.display_type not in ('line_note', 'line_section')" name="account_invoice_line_accountable">
                                     <td name="account_invoice_line_name">
-                                        <t t-set="translation_name" t-value="line.with_context(lang='ar_001').product_id.name"/>
                                         <t t-if="line.product_id">
-                                            <span t-field="line.product_id.name" t-options="{'widget': 'text'}"/>
-                                            <t t-if="line.product_id.name != translation_name">
+                                            <t t-set="arabic_name" t-value="line.with_context(lang='ar_001').product_id.display_name"/>
+                                            <t t-set="english_name" t-value="line.with_context(lang='en_US').product_id.display_name"/>
+
+                                            <span t-field="line.product_id.display_name"
+                                                t-options="{'widget': 'text'}"/>
+
+                                            <t t-if="arabic_name != english_name">
                                                 <br/>
                                                 <span t-field="line.with_context(lang='ar_001').product_id.name"
-                                                      t-options="{'widget': 'text'}"/>
+                                                    style="text:right"
+                                                    t-options="{'widget': 'text'}"/>
+                                            </t>
+
+                                            <t t-if="line.name != english_name and line.name != arabic_name">
+                                                <br/>
+                                                <span t-field="line.name" t-options="{'widget': 'text'}"/>
                                             </t>
                                         </t>
-                                        <t t-if="line.name and line.name != line.product_id.name and line.name != translation_name">
-                                            <t t-if="line.product_id"><br/></t>
+                                        <t t-else="">
                                             <span t-field="line.name" t-options="{'widget': 'text'}"/>
                                         </t>
                                     </td>