From 954c85dc960fcf51fc762cfb937707609667faf6 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Tue, 17 May 2022 09:53:48 +0000
Subject: [PATCH] [FIX] account: tests

It seems most accounting tests relied on the fact that the "accountman"
test user has both the user AND manager groups (but previously, the
manager group was given by the implied group relation "Settings" ->
"account manager")

Part-of: odoo/odoo#91909
---
 addons/account/security/account_security.xml    | 2 +-
 addons/account/tests/common.py                  | 6 +++++-
 addons/account/tests/test_account_onboarding.py | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/addons/account/security/account_security.xml b/addons/account/security/account_security.xml
index 662c803525f..c68da09d4b3 100644
--- a/addons/account/security/account_security.xml
+++ b/addons/account/security/account_security.xml
@@ -75,7 +75,7 @@
     </record>
 
     <record id="base.user_admin" model="res.users">
-        <field name="groups_id" eval="[(4, ref('account.group_account_invoice'))]"/>
+        <field name="groups_id" eval="[(4, ref('account.group_account_manager'))]"/>
     </record>
 
     <record id="group_warning_account" model="res.groups">
diff --git a/addons/account/tests/common.py b/addons/account/tests/common.py
index 2f8af2578be..7b0515bf16c 100644
--- a/addons/account/tests/common.py
+++ b/addons/account/tests/common.py
@@ -46,7 +46,11 @@ class AccountTestInvoicingCommon(TransactionCase):
             'name': 'Because I am accountman!',
             'login': 'accountman',
             'password': 'accountman',
-            'groups_id': [(6, 0, cls.env.user.groups_id.ids), (4, cls.env.ref('account.group_account_user').id)],
+            'groups_id': [
+                (6, 0, cls.env.user.groups_id.ids),
+                (4, cls.env.ref('account.group_account_manager').id),
+                (4, cls.env.ref('account.group_account_user').id),
+            ],
         })
         user.partner_id.email = 'accountman@test.com'
 
diff --git a/addons/account/tests/test_account_onboarding.py b/addons/account/tests/test_account_onboarding.py
index c2b9c472eac..aedb9d4dba4 100644
--- a/addons/account/tests/test_account_onboarding.py
+++ b/addons/account/tests/test_account_onboarding.py
@@ -13,7 +13,7 @@ class TestTourRenderInvoiceReport(AccountTestInvoicingHttpCommon):
 
         cls.env.user.write({
             'groups_id': [
-                (6, 0, (cls.env.ref('account.group_account_invoice') + cls.env.ref('base.group_system')).ids),
+                (6, 0, (cls.env.ref('account.group_account_manager') + cls.env.ref('base.group_system')).ids),
             ],
         })