From 95382452674a61bf7293c9b96345934a4f20a667 Mon Sep 17 00:00:00 2001
From: "Lucas Perais (lpe)" <lpe@odoo.com>
Date: Thu, 14 Nov 2019 13:30:20 +0000
Subject: [PATCH] [IMP] *: adapt views for phone widget sms enabled default

Task 2123526

This commit adapts the views to take into account
that the phone widget enables sending an sms by default

*: crm, hr, sms, base
---
 addons/crm/views/crm_lead_views.xml          |  8 ++++----
 addons/hr/views/hr_employee_public_views.xml |  4 ++--
 addons/hr/views/res_users.xml                |  8 ++++----
 addons/sms/views/res_partner_views.xml       |  2 +-
 odoo/addons/base/views/res_partner_views.xml | 12 ++++++------
 odoo/addons/base/views/res_users_views.xml   |  4 ++--
 6 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index 6302ab07066..53a0ea56667 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -179,7 +179,7 @@
                                     <field name="partner_address_email"
                                         attrs="{'invisible': [('partner_address_email', '=', False)]}" widget="email" string="Email"/>
                                 </div>
-                                <field name="phone" widget="phone" options="{'enable_sms': True}"/>
+                                <field name="phone" widget="phone"/>
                             </group>
                             <group name="lead_info" attrs="{'invisible': [('type', '=', 'opportunity')]}">
                                 <label for="contact_name"/>
@@ -198,8 +198,8 @@
                                 </div>
                                 <field name="email_cc" groups="base.group_no_one"/>
                                 <field name="function"/>
-                                <field name="phone" widget="phone" options="{'enable_sms': True}"/>
-                                <field name="mobile" widget="phone" options="{'enable_sms': True}"/>
+                                <field name="phone" widget="phone"/>
+                                <field name="mobile" widget="phone"/>
                             </group>
                             <group attrs="{'invisible': [('type', '=', 'lead')]}">
                                 <field name="date_deadline"/>
@@ -271,7 +271,7 @@
                                             <field name="title" placeholder="Title" domain="[]" options='{"no_open": True}'/>
                                         </div>
                                         <field name="function"/>
-                                        <field name="mobile" widget="phone" options="{'enable_sms': True}"/>
+                                        <field name="mobile" widget="phone"/>
                                     </group>
                                     <group string="Marketing">
                                         <field name="campaign_id" />
diff --git a/addons/hr/views/hr_employee_public_views.xml b/addons/hr/views/hr_employee_public_views.xml
index d27d4404abe..e56058b50d5 100644
--- a/addons/hr/views/hr_employee_public_views.xml
+++ b/addons/hr/views/hr_employee_public_views.xml
@@ -51,8 +51,8 @@
                             </div>
                             <group>
                                 <group>
-                                    <field name="mobile_phone" widget="phone"/>
-                                    <field name="work_phone" widget="phone"/>
+                                    <field name="mobile_phone" widget="phone" options="{'enable_sms': false}"/>
+                                    <field name="work_phone" widget="phone" options="{'enable_sms': false}"/>
                                     <field name="work_email" widget="email"/>
                                     <field name="work_location"/>
                                 </group>
diff --git a/addons/hr/views/res_users.xml b/addons/hr/views/res_users.xml
index 8a7106fbe98..c5724bd8fc1 100644
--- a/addons/hr/views/res_users.xml
+++ b/addons/hr/views/res_users.xml
@@ -96,8 +96,8 @@
                         <group>
                             <group>
                                 <field name="can_edit" invisible="1"/>
-                                <field name="mobile_phone" widget="phone" attrs="{'readonly': [('can_edit', '=', False)]}"/>
-                                <field name="work_phone" widget="phone" attrs="{'readonly': [('can_edit', '=', False)]}"/>
+                                <field name="mobile_phone" widget="phone" attrs="{'readonly': [('can_edit', '=', False)]}" options="{'enable_sms': false}"/>
+                                <field name="work_phone" widget="phone" attrs="{'readonly': [('can_edit', '=', False)]}" options="{'enable_sms': false}"/>
                             </group>
                             <group>
                                 <field name="work_email" widget="email" attrs="{'readonly': [('can_edit', '=', False)]}"/>
@@ -139,7 +139,7 @@
                                             options='{"always_reload": True, "highlight_first_line": True}'
                                             attrs="{'readonly': [('can_edit', '=', False)]}"/>
                                         <field name="private_email" string="Email" attrs="{'readonly': [('can_edit', '=', False)]}"/>
-                                        <field name="employee_phone" string="Phone" attrs="{'readonly': [('can_edit', '=', False)]}"/>
+                                        <field name="employee_phone" string="Phone" attrs="{'readonly': [('can_edit', '=', False)]}" options="{'enable_sms': false}"/>
                                         <field name="employee_bank_account_id" attrs="{'readonly': [('can_edit', '=', False)]}"/>
                                         <field name="km_home_work" attrs="{'readonly': [('can_edit', '=', False)]}"/>
                                     </group>
@@ -167,7 +167,7 @@
                                     </group>
                                     <group string="Emergency">
                                         <field name="emergency_contact" attrs="{'readonly': [('can_edit', '=', False)]}"/>
-                                        <field name="emergency_phone" attrs="{'readonly': [('can_edit', '=', False)]}"/>
+                                        <field name="emergency_phone" attrs="{'readonly': [('can_edit', '=', False)]}" options="{'enable_sms': false}"/>
                                     </group>
                                     <group string="Work Permit" name="work_permit">
                                         <field name="visa_no" attrs="{'readonly': [('can_edit', '=', False)]}"/>
diff --git a/addons/sms/views/res_partner_views.xml b/addons/sms/views/res_partner_views.xml
index 91c6b77c9b2..c30e5a84f91 100644
--- a/addons/sms/views/res_partner_views.xml
+++ b/addons/sms/views/res_partner_views.xml
@@ -14,7 +14,7 @@
             <xpath expr="//field[@name='phone']" position="replace">
                 <label for="phone"/>
                 <div class="o_row">
-                    <field name="phone" widget="phone" options="{'enable_sms': True}"/>
+                    <field name="phone" widget="phone"/>
                 </div>
             </xpath>
             <xpath expr="//field[@name='mobile']" position="replace">
diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index cb3624983bf..e25b193fa77 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -84,8 +84,8 @@
                         <field name="function" placeholder="e.g. Sales Director" attrs="{'invisible': [('is_company','=', True)]}"/>
                         <field name="user_ids" invisible="1"/>
                         <field name="email" widget="email" context="{'gravatar_image': True}" required="context.get('force_email', False)" attrs="{'required': [('user_ids','!=', [])]}"/>
-                        <field name="phone" widget="phone"/>
-                        <field name="mobile" widget="phone"/>
+                        <field name="phone" widget="phone" options="{'enable_sms': false}"/>
+                        <field name="mobile" widget="phone" options="{'enable_sms': false}"/>
                     </group>
                 </form>
             </field>
@@ -184,8 +184,8 @@
                         <group>
                             <field name="function" placeholder="e.g. Sales Director"
                                 attrs="{'invisible': [('is_company','=', True)]}"/>
-                            <field name="phone" widget="phone"/>
-                            <field name="mobile" widget="phone"/>
+                            <field name="phone" widget="phone" options="{'enable_sms': false}"/>
+                            <field name="mobile" widget="phone" options="{'enable_sms': false}"/>
                             <field name="email" widget="email" context="{'gravatar_image': True}"/>
                         </group>
                     </group>
@@ -441,8 +441,8 @@
                                 </div>
                             </group>
                             <group>
-                                <field name="phone" widget="phone"/>
-                                <field name="mobile" widget="phone"/>
+                                <field name="phone" widget="phone" options="{'enable_sms': false}"/>
+                                <field name="mobile" widget="phone" options="{'enable_sms': false}"/>
                                 <field name="email"/>
                             </group>
                         </group>
diff --git a/odoo/addons/base/views/res_users_views.xml b/odoo/addons/base/views/res_users_views.xml
index 8955e9d3873..50008ead434 100644
--- a/odoo/addons/base/views/res_users_views.xml
+++ b/odoo/addons/base/views/res_users_views.xml
@@ -144,8 +144,8 @@
                             <div attrs="{'invisible': [('id', '>', 0)]}" groups="base.group_no_one">
                                 <field name="groups_id" readonly="1" widget="many2many_tags" options="{'color_field': 'color'}" style="display: inline;"/> You will be able to define additional access rights by editing the newly created user under the Settings / Users menu.
                             </div>
-                            <field name="phone" widget="phone"/>
-                            <field name="mobile" widget="phone"/>
+                            <field name="phone" widget="phone" options="{'enable_sms': false}"/>
+                            <field name="mobile" widget="phone" options="{'enable_sms': false}"/>
                         </group>
                     </sheet>
                 </form>