From 952fa8225f29ff021b421e1add8736909dd3427f Mon Sep 17 00:00:00 2001
From: "Audric Onockx (auon)" <auon@odoo.com>
Date: Tue, 8 Feb 2022 12:35:45 +0000
Subject: [PATCH] [FIX] project : forbid subtask assignment to portal user

Steps :
Go to a Task > Sub-Tasks > Assignee

Issue :
You can assign a portal user

Fix :
Add ('share', '=', False) to user_ids domain

closes odoo/odoo#84214

Opw: 2759085
X-original-commit: 6a2936c700d19c109db8f1adb06c7de1b8cf2403
Related: odoo/enterprise#24169
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
---
 addons/project/views/project_views.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index c59a5705dfe..4723150ab40 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -946,7 +946,7 @@
                                     <field name="name"/>
                                     <field name="display_project_id" string="Project" optional="hide"/>
                                     <field name="partner_id" optional="hide"/>
-                                    <field name="user_ids" widget="many2many_avatar_user" optional="show" domain="[('active', '=', True)]"/>
+                                    <field name="user_ids" widget="many2many_avatar_user" optional="show" domain="[('share', '=', False), ('active', '=', True)]"/>
                                     <field name="company_id" groups="base.group_multi_company" optional="hide"/>
                                     <field name="activity_ids" widget="list_activity" optional="hide"/>
                                     <field name="date_deadline" attrs="{'invisible': [('is_closed', '=', True)]}" optional="show"/>
@@ -963,7 +963,7 @@
                                     <field name="is_closed" invisible="1" />
                                     <field name="name" />
                                     <field name="project_id" optional="hide" />
-                                    <field name="user_ids" widget="many2many_avatar_user" optional="show" domain="[('active', '=', True)]"/>
+                                    <field name="user_ids" widget="many2many_avatar_user" optional="show" domain="[('share', '=', False), ('active', '=', True)]"/>
                                     <field name="company_id" optional="hide" groups="base.group_multi_company" />
                                     <field name="activity_ids" widget="list_activity" optional="hide"/>
                                     <field name="date_deadline" attrs="{'invisible': [('is_closed', '=', True)]}" optional="show" />
@@ -1206,7 +1206,7 @@
                     <field name="project_id" widget="project_private_task" optional="show" readonly="1"/>
                     <field name="partner_id" optional="hide"/>
                     <field name="parent_id" optional="hide" attrs="{'invisible': [('allow_subtasks', '=', False)]}" groups="base.group_no_one"/>
-                    <field name="user_ids" optional="show" widget="many2many_avatar_user" domain="[('active', '=', True)]"/>
+                    <field name="user_ids" optional="show" widget="many2many_avatar_user" domain="[('share', '=', False), ('active', '=', True)]"/>
                     <field name="company_id" groups="base.group_multi_company" optional="show"/>
                     <field name="activity_ids" widget="list_activity" optional="show"/>
                     <field name="date_deadline" optional="hide" widget="remaining_days" attrs="{'invisible': [('is_closed', '=', True)]}"/>