From 937fd7a14c4c3c63a0769a92f7eb128a83bfa640 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 10 Jan 2012 11:01:03 +0100 Subject: [PATCH] [IMP] web_diagram: dict.update call, use kwargs instead of creating an immediately discarded dict in-place bzr revid: xmo@openerp.com-20120110100103-h7gghm1lzg5h6a2l --- addons/web_diagram/controllers/main.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/addons/web_diagram/controllers/main.py b/addons/web_diagram/controllers/main.py index 55047804725..2c0bcffb9d6 100644 --- a/addons/web_diagram/controllers/main.py +++ b/addons/web_diagram/controllers/main.py @@ -64,13 +64,13 @@ class DiagramView(View): for tr in data_connectors: - t = connectors.get(str(tr['id'])) - t.update({ - 'source': tr[src_node][1], - 'destination': tr[des_node][1], - 'options': {}, - 'signal': tr['signal'] - }) + t = connectors[str(tr['id'])] + t.update( + source=tr[src_node][1], + destination=tr[des_node][1], + options={}, + signal=tr.get('signal') + ) for i, fld in enumerate(connector_fields): t['options'][connector_fields_string[i]] = tr[fld] @@ -87,7 +87,7 @@ class DiagramView(View): if not n: n = isolate_nodes.get(act['id'], {}) y_max += 140 - n.update({'x': 20, 'y': y_max}) + n.update(x=20, y=y_max) nodes[act['id']] = n n.update(