From 937c2fc70841e39031100662db74d793ce68a8ea Mon Sep 17 00:00:00 2001 From: jem-odoo Date: Fri, 6 Jul 2018 15:16:44 +0200 Subject: [PATCH] [FIX] sale_timesheet: remaining calculation in plan project The computation is badly implemented. Wrong data struture used at the wrong moment. This commit fixes it: remaing hour in overview is SOLD qty - DONE qty (sum of timesheets). Task #1857652 --- addons/sale_timesheet/controllers/main.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addons/sale_timesheet/controllers/main.py b/addons/sale_timesheet/controllers/main.py index 6ed6d0a8ae2..f3e5bb80e85 100644 --- a/addons/sale_timesheet/controllers/main.py +++ b/addons/sale_timesheet/controllers/main.py @@ -197,9 +197,8 @@ class SaleTimesheetController(http.Controller): # remaining computation of SO row, as Sold - Done (timesheet total) for sale_order_id, done_sold_vals in rows_sale_order_done_sold.items(): - item = done_sold_vals.get(sale_order_id) - if item: - rows_sale_order[sale_order_id] = item['sold'] - item['done'] + if sale_order_id in rows_sale_order: + rows_sale_order[sale_order_id][-1] = done_sold_vals['sold'] - done_sold_vals['done'] # group rows SO, SOL and their related employee rows. timesheet_forecast_table_rows = []