From 933165ec3afa0676de4b2f3662c4c1bb2f97efc5 Mon Sep 17 00:00:00 2001 From: Martin Trigaux Date: Thu, 11 Oct 2018 12:11:19 +0000 Subject: [PATCH] [FIX] models: restore warning on wrong record Was lost during d5b687a48ffb Set the module name in the context to be able to detect errors in xml and csv import closes odoo/odoo#27680 --- odoo/models.py | 8 ++++++++ odoo/tools/convert.py | 2 ++ 2 files changed, 10 insertions(+) diff --git a/odoo/models.py b/odoo/models.py index fe3a9dd4781..ce3bfdee9b6 100644 --- a/odoo/models.py +++ b/odoo/models.py @@ -3791,6 +3791,14 @@ class BaseModel(MetaModel('DummyModel', (object,), {'_register': False})): else: imd.browse(d_id).unlink() + # check for records to create with an XMLID from another module + module = self.env.context.get('install_module') + if module: + prefix = module + "." + for data in to_create: + if data.get('xml_id') and not data['xml_id'].startswith(prefix): + _logger.warning("Creating record %s in module %s.", data['xml_id'], module) + # create records records = self.create([data['values'] for data in to_create]) for data, record in pycompat.izip(to_create, records): diff --git a/odoo/tools/convert.py b/odoo/tools/convert.py index a9a3796a34a..b98e586a62e 100644 --- a/odoo/tools/convert.py +++ b/odoo/tools/convert.py @@ -832,6 +832,8 @@ def convert_csv_import(cr, module, fname, csvcontent, idref=None, mode='init', context = { 'mode': mode, 'module': module, + 'install_module': module, + 'install_filename': fname, 'noupdate': noupdate, } env = odoo.api.Environment(cr, SUPERUSER_ID, context)