From 92daf621b5d2f024e881dac944e01114b049cdaf Mon Sep 17 00:00:00 2001
From: FrancoisGe <fge@odoo.com>
Date: Mon, 30 Oct 2023 11:08:21 +0100
Subject: [PATCH] [REF] stock: don't use "extension" mode for custom component

It's bad practice to use the "extension" inheritance mode for a custom
component. In this case, inheritance is only necessary for the
"StockMoveX2ManyField" custom field.
In this commit, we will therefore use primary mode to generate a custom
template used only by "StockMoveX2ManyField".

closes odoo/odoo#140301

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
---
 .../stock/static/src/views/picking_form/stock_move_one2many.js  | 2 ++
 .../stock/static/src/views/picking_form/stock_move_one2many.xml | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/stock/static/src/views/picking_form/stock_move_one2many.js b/addons/stock/static/src/views/picking_form/stock_move_one2many.js
index 789ce0f5c23..4a505d23d1d 100644
--- a/addons/stock/static/src/views/picking_form/stock_move_one2many.js
+++ b/addons/stock/static/src/views/picking_form/stock_move_one2many.js
@@ -5,6 +5,8 @@ import { ListRenderer } from "@web/views/list/list_renderer";
 import { X2ManyField, x2ManyField } from "@web/views/fields/x2many/x2many_field";
 
 export class MovesListRenderer extends ListRenderer {
+    static recordRowTemplate = "stock.MovesListRenderer.RecordRow";
+
     processAllColumn(allColumns, list) {
         let cols = super.processAllColumn(...arguments);
         if (list.resModel === "stock.move") {
diff --git a/addons/stock/static/src/views/picking_form/stock_move_one2many.xml b/addons/stock/static/src/views/picking_form/stock_move_one2many.xml
index a7cacde0eb0..486814f8725 100644
--- a/addons/stock/static/src/views/picking_form/stock_move_one2many.xml
+++ b/addons/stock/static/src/views/picking_form/stock_move_one2many.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <templates xml:space="preserve">
-    <t t-inherit-mode="extension" t-inherit="web.ListRenderer.RecordRow">
+    <t t-name="stock.MovesListRenderer.RecordRow" t-inherit-mode="primary" t-inherit="web.ListRenderer.RecordRow">
         <xpath expr="//tr/t[1]" position="inside">
             <t t-if="column.type === 'opendetailsop'">
                 <td class="o_data_cell cursor-pointer o_list_button">