From 91f57b09dc90e17cdb3d9f19403f6ba0fd831d01 Mon Sep 17 00:00:00 2001 From: root Date: Sat, 5 Dec 2020 14:19:23 +0000 Subject: [PATCH] [FIX] website_sale: compare id with id instead of record MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit Odoo tries to compare an 'account.fiscal.position' id with an 'account.fiscal.position' record. This causes a 'Comparing apples and oranges' warning in the logs and is not the right way to do this. This is a fix for d89fa970e8e5b07f1b9a396e6ee02db7fdd136e4 where this issue was introduced closes odoo/odoo#63029 X-original-commit: d9a1b28144523ece2c6fa4329f3ae4b7ff4a38ec Signed-off-by: Jérémy Kersten (jke) --- addons/website_sale/models/website.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_sale/models/website.py b/addons/website_sale/models/website.py index c924bbb886e..515000d9e15 100644 --- a/addons/website_sale/models/website.py +++ b/addons/website_sale/models/website.py @@ -264,7 +264,7 @@ class Website(models.Model): self.env['account.fiscal.position'].sudo() .with_company(sale_order.company_id.id) .get_fiscal_position(sale_order.partner_id.id, delivery_id=sale_order.partner_shipping_id.id) - ) + ).id if sale_order.fiscal_position_id.id != fpos_id: sale_order = None