From 91e7dfd63a1cf376c7bacf21083a57ce52c279af Mon Sep 17 00:00:00 2001
From: Aaron Bohy <aab@odoo.com>
Date: Fri, 30 Sep 2022 06:28:38 +0000
Subject: [PATCH] [FIX] web: FieldTooltip: display component description in
 debug

In debug, we want to see the field component description in its
tooltip. For instance, for a many2one: `Widget: Many2one (many2one)`,
`Many2one` being the `displayName` attribute of the Component, and
`many2one` the key in the registry (to use with `widget="many2one"`
in archs).

X-original-commit: 39fbb4620b5e846cd597ecbbfefdbda8bc4cb8e1
Part-of: odoo/odoo#101787
---
 addons/web/static/src/views/fields/field_tooltip.js  |  2 +-
 addons/web/static/src/views/fields/field_tooltip.xml |  6 +++---
 .../web/static/tests/views/form/form_view_tests.js   | 12 +++++++++---
 3 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/addons/web/static/src/views/fields/field_tooltip.js b/addons/web/static/src/views/fields/field_tooltip.js
index 49dad72a1be..9f62ebe4bba 100644
--- a/addons/web/static/src/views/fields/field_tooltip.js
+++ b/addons/web/static/src/views/fields/field_tooltip.js
@@ -9,7 +9,7 @@ export function getTooltipInfo(params) {
             const widget = fieldRegistry.get(params.fieldInfo.widget);
             widgetDescription = widget.prototype.description;
         } else {
-            widgetDescription = params.fieldInfo.FieldComponent.description;
+            widgetDescription = params.fieldInfo.FieldComponent.displayName;
         }
     }
 
diff --git a/addons/web/static/src/views/fields/field_tooltip.xml b/addons/web/static/src/views/fields/field_tooltip.xml
index 1bdfa8b1871..6b7c01c541f 100644
--- a/addons/web/static/src/views/fields/field_tooltip.xml
+++ b/addons/web/static/src/views/fields/field_tooltip.xml
@@ -24,9 +24,9 @@
                 <li t-if="field.widget" data-item="widget">
                     <span class="o-tooltip--technical--title">Widget:</span>
                     <t t-if="field.widgetDescription" t-esc="field.widgetDescription"/>
-                    <t t-if="field.widgetDescription"> (</t>
-                    <t t-esc="field.widget"/>
-                    <t t-if="field.widgetDescription">)</t>
+                    <t t-if="field.widget">
+                        (<t t-esc="field.widget"/>)
+                    </t>
                 </li>
                 <li t-if="field.context" data-item="context">
                     <span class="o-tooltip--technical--title">Context:</span>
diff --git a/addons/web/static/tests/views/form/form_view_tests.js b/addons/web/static/tests/views/form/form_view_tests.js
index 8017b9bad89..4f7408f4363 100644
--- a/addons/web/static/tests/views/form/form_view_tests.js
+++ b/addons/web/static/tests/views/form/form_view_tests.js
@@ -2881,7 +2881,13 @@ QUnit.module("Views", (hooks) => {
         assert.verifySteps(["willUpdateProps", "read2", "willUpdateProps", "willUpdateProps"]);
 
         await click(target.querySelector(".o_form_statusbar button.p"));
-        assert.verifySteps(["willUpdateProps", "willUpdateProps", "read3", "willUpdateProps", "willUpdateProps"]);
+        assert.verifySteps([
+            "willUpdateProps",
+            "willUpdateProps",
+            "read3",
+            "willUpdateProps",
+            "willUpdateProps",
+        ]);
     });
 
     QUnit.test("buttons in form view, new record", async function (assert) {
@@ -9534,8 +9540,8 @@ QUnit.module("Views", (hooks) => {
             "widget should be present for this field"
         );
         assert.strictEqual(
-            target.querySelector('.o-tooltip--technical > li[data-item="widget"]').textContent,
-            "Widget:many2one",
+            target.querySelector(".o-tooltip--technical > li[data-item=widget]").textContent.trim(),
+            "Widget:Many2one (many2one)",
             "widget description should be correct"
         );
     });