From 91d25c932f26eeca9913d85715d836f253fc0d89 Mon Sep 17 00:00:00 2001
From: "Xavier BOL (xbo)" <xbo@odoo.com>
Date: Fri, 9 Sep 2022 14:47:02 +0000
Subject: [PATCH] [IMP] project,hr_timesheet: no open project in list view

Before this commit, the project field in task and timesheet models is
clickable in list view of those models.

This commit prevents to open the form view in the list view since the
form view of project is now more a view to configuration the project and
so once the configuration is done, the user will not always need to go
to that view.

closes odoo/odoo#99949

Related: odoo/enterprise#31212
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
---
 addons/hr_timesheet/views/hr_timesheet_views.xml | 2 +-
 addons/project/views/project_views.xml           | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/addons/hr_timesheet/views/hr_timesheet_views.xml b/addons/hr_timesheet/views/hr_timesheet_views.xml
index d50c69d14b4..1b52e0cc96c 100644
--- a/addons/hr_timesheet/views/hr_timesheet_views.xml
+++ b/addons/hr_timesheet/views/hr_timesheet_views.xml
@@ -25,7 +25,7 @@
                 <tree editable="bottom" string="Timesheet Activities" sample="1">
                     <field name="date"/>
                     <field name="employee_id" invisible="1"/>
-                    <field name="project_id" required="1" options="{'no_create_edit': True}"/>
+                    <field name="project_id" required="1" options="{'no_create_edit': True, 'no_open': 1}"/>
                     <field name="task_id" optional="show" options="{'no_create_edit': True, 'no_open': True}" widget="task_with_hours" context="{'default_project_id': project_id}"/>
                     <field name="name" optional="show" required="0"/>
                     <field name="tag_ids" groups="analytic.group_analytic_tags" widget="many2many_tags" optional="hide"/>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 363798f7ebb..3f240e547ff 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -1185,7 +1185,7 @@
                                     <field name="child_text" invisible="1"/>
                                     <field name="allow_subtasks" invisible="1"/>
                                     <field name="name" widget="name_with_subtask_count"/>
-                                    <field name="display_project_id" string="Project" optional="hide"/>
+                                    <field name="display_project_id" string="Project" optional="hide" options="{'no_open': 1}"/>
                                     <field name="milestone_id"
                                         optional="hide"
                                         context="{'default_project_id': display_project_id or project_id}"
@@ -1220,7 +1220,7 @@
                                     <field name="allow_subtasks" invisible="1"/>
                                     <field name="name" widget="name_with_subtask_count"/>
                                     <field name="id" optional="hide"/>
-                                    <field name="project_id" optional="hide" />
+                                    <field name="project_id" optional="hide" options="{'no_open': 1}" />
                                     <field name="milestone_id"
                                         optional="hide"
                                         context="{'default_project_id': project_id if not parent_id or not display_project_id else display_project_id}"
@@ -1485,7 +1485,7 @@
                     <field name="child_text" invisible="1"/>
                     <field name="allow_subtasks" invisible="1"/>
                     <field name="name" widget="name_with_subtask_count"/>
-                    <field name="project_id" widget="project_private_task" optional="show" readonly="1"/>
+                    <field name="project_id" widget="project_private_task" optional="show" readonly="1" options="{'no_open': 1}"/>
                     <field name="milestone_id" attrs="{'invisible': [('allow_milestones', '=', False)]}" context="{'default_project_id': project_id}" groups="project.group_project_milestone"/>
                     <field name="partner_id" optional="hide"/>
                     <field name="parent_id" optional="hide" attrs="{'invisible': [('allow_subtasks', '=', False)]}" groups="base.group_no_one"/>
@@ -1517,7 +1517,7 @@
                 <tree string="Next Activities" decoration-danger="not is_closed and activity_date_deadline &lt; current_date" default_order="activity_date_deadline" multi_edit="1">
                     <field name="is_closed"/>
                     <field name="name"/>
-                    <field name="project_id"/>
+                    <field name="project_id" options="{'no_open': 1}"/>
                     <field name="activity_date_deadline"/>
                     <field name="activity_type_id"/>
                     <field name="activity_summary"/>