From 91507c1d39b4083539d2ad97d9b55f3fdbc8ecd0 Mon Sep 17 00:00:00 2001
From: Kevin Baptiste <kba@odoo.com>
Date: Tue, 22 Mar 2022 08:18:49 +0000
Subject: [PATCH] [IMP] hr_{contract,skills}: re-organize Settings menu

Taskid: 2796407
Part-of: odoo/odoo#87082
---
 addons/hr/views/hr_views.xml                  | 52 +++++++++++--------
 .../hr_contract/views/hr_contract_views.xml   |  2 +-
 addons/hr_skills/views/hr_views.xml           |  6 +--
 3 files changed, 33 insertions(+), 27 deletions(-)

diff --git a/addons/hr/views/hr_views.xml b/addons/hr/views/hr_views.xml
index 4e7cfa3cf9c..614ae1a35d4 100644
--- a/addons/hr/views/hr_views.xml
+++ b/addons/hr/views/hr_views.xml
@@ -57,23 +57,16 @@
             sequence="100"/>
 
             <menuitem
-                id="menu_view_hr_job"
-                action="action_hr_job"
+                id="menu_config_employee"
+                name="Employee"
                 parent="menu_human_resources_configuration"
-                sequence="1"/>
-
-            <menuitem
-                id="menu_view_employee_category_form"
-                name="Tags"
-                action="open_view_categ_form"
-                parent="menu_human_resources_configuration"
-                groups="base.group_no_one"
-                sequence="2"/>
+                groups="group_hr_user"
+                sequence="10"/>
 
             <menuitem
                 id="menu_hr_department_tree"
                 action="hr_department_tree_action"
-                parent="menu_human_resources_configuration"
+                parent="menu_config_employee"
                 sequence="4"
                 groups="group_hr_user"/>
 
@@ -86,17 +79,38 @@
             <menuitem
                 id="menu_hr_work_location_tree"
                 action="hr_work_location_action"
-                parent="menu_human_resources_configuration"
+                parent="menu_config_employee"
                 sequence="5"
                 groups="group_hr_user"/>
 
             <menuitem
                 id="menu_hr_departure_reason_tree"
                 action="hr_departure_reason_action"
-                parent="menu_human_resources_configuration"
+                parent="menu_config_employee"
                 sequence="5"
                 groups="group_hr_user"/>
 
+            <menuitem
+                id="menu_view_employee_category_form"
+                name="Tags"
+                action="open_view_categ_form"
+                parent="menu_config_employee"
+                groups="base.group_no_one"
+                sequence="10"/>
+
+            <menuitem
+                id="menu_config_recruitment"
+                name="Recruitment"
+                parent="menu_human_resources_configuration"
+                groups="group_hr_user"
+                sequence="20"/>
+
+                <menuitem
+                    id="menu_view_hr_job"
+                    action="action_hr_job"
+                    parent="menu_config_recruitment"
+                    sequence="1"/>
+
             <menuitem
                 id="menu_config_plan"
                 name="Activity Planning"
@@ -104,17 +118,9 @@
                 groups="group_hr_manager"
                 sequence="100"/>
 
-                <menuitem
-                    id="menu_config_plan_types"
-                    name="Plan Activities"
-                    action="hr_plan_activity_type_action"
-                    parent="menu_config_plan"
-                    groups="base.group_no_one"
-                    sequence="99"/>
-
                 <menuitem
                     id="menu_config_plan_plan"
-                    name="Plans"
+                    name="On/Offboarding Plans"
                     action="hr_plan_action"
                     parent="menu_config_plan"
                     groups="group_hr_manager"
diff --git a/addons/hr_contract/views/hr_contract_views.xml b/addons/hr_contract/views/hr_contract_views.xml
index c26e2133063..80cdf69cc86 100644
--- a/addons/hr_contract/views/hr_contract_views.xml
+++ b/addons/hr_contract/views/hr_contract_views.xml
@@ -311,6 +311,6 @@
             id="menu_human_resources_configuration_contract"
             name="Contracts"
             parent="hr.menu_human_resources_configuration"
-            sequence="3"/>
+            sequence="25"/>
 
 </odoo>
diff --git a/addons/hr_skills/views/hr_views.xml b/addons/hr_skills/views/hr_views.xml
index 13c8b7ac3a3..3614e9af29e 100644
--- a/addons/hr_skills/views/hr_views.xml
+++ b/addons/hr_skills/views/hr_views.xml
@@ -194,7 +194,7 @@
             id="menu_human_resources_configuration_resume"
             name="Resumé"
             parent="hr.menu_human_resources_configuration"
-            sequence="4"
+            sequence="15"
             groups="base.group_no_one"/>
 
     <menuitem
@@ -362,7 +362,7 @@
         id="hr_skill_type_menu"
         name="Skill Types"
         action="hr_skill_type_action"
-        parent="hr.menu_human_resources_configuration"
-        sequence="3"
+        parent="hr.menu_config_employee"
+        sequence="7"
         groups="hr.group_hr_user"/>
 </odoo>