From 9073ecb6f59e1834bdd5e1aed96d6be4b03b00d5 Mon Sep 17 00:00:00 2001 From: Christophe Simonis Date: Fri, 6 Jan 2017 17:55:04 +0100 Subject: [PATCH] [FIX] core: effectively warn on invalid custom views Since new-api migration of `ir.ui.view`, the method that check views raises exceptions instead of returning a boolean. Show them as warning. Related to #14521 --- openerp/modules/loading.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/openerp/modules/loading.py b/openerp/modules/loading.py index f8bae40ad37..c6c738b07b2 100644 --- a/openerp/modules/loading.py +++ b/openerp/modules/loading.py @@ -404,8 +404,10 @@ def load_modules(db, force_demo=False, status=None, update_module=False): if update_module: Views = registry['ir.ui.view'] for model in registry.models.keys(): - if not Views._validate_custom_views(cr, SUPERUSER_ID, model): - _logger.warning('Invalid custom view(s) for model %s', model) + try: + Views._validate_custom_views(cr, SUPERUSER_ID, model) + except Exception as e: + _logger.warning('invalid custom view(s) for model %s: %s', model, tools.ustr(e)) if report.failures: _logger.error('At least one test failed when loading the modules.')