From 8fd2455742ec944e953dcc4b5d216222eb6dffee Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Mon, 12 Aug 2019 09:29:39 +0000
Subject: [PATCH] [MOV] sale_management -> sale: invoice creation from
 sale_order.

Enable invoice management from sale order in all modules having sale as dependency.

closes odoo/odoo#35658

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
---
 addons/sale/__manifest__.py                   |  1 +
 addons/sale/views/product_views.xml           | 17 ++++++++++
 addons/sale/views/sale_views.xml              | 12 +++++--
 .../views/sale_management_views.xml           | 33 -------------------
 4 files changed, 28 insertions(+), 35 deletions(-)
 create mode 100644 addons/sale/views/product_views.xml

diff --git a/addons/sale/__manifest__.py b/addons/sale/__manifest__.py
index 5ec327926df..103675543d6 100644
--- a/addons/sale/__manifest__.py
+++ b/addons/sale/__manifest__.py
@@ -33,6 +33,7 @@ This module contains all the common features of Sales Management and eCommerce.
         'views/res_config_settings_views.xml',
         'views/payment_views.xml',
         'views/product_attribute_views.xml',
+        'views/product_views.xml',
         'views/utm_campaign_views.xml'
     ],
     'demo': [
diff --git a/addons/sale/views/product_views.xml b/addons/sale/views/product_views.xml
new file mode 100644
index 00000000000..1142887a07e
--- /dev/null
+++ b/addons/sale/views/product_views.xml
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<odoo>
+
+    <record model="ir.ui.view" id="product_template_sale_form_view">
+        <field name="name">product.template.sales</field>
+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="product.product_template_form_view"/>
+        <field name="arch" type="xml">
+            <xpath expr="//group[@name='sale']" position="attributes">
+                <attribute name="invisible">0</attribute>
+            </xpath>
+            <xpath expr="//group[@name='invoicing']" position="attributes">
+                <attribute name="invisible">0</attribute>
+            </xpath>
+        </field>
+    </record>
+</odoo>
diff --git a/addons/sale/views/sale_views.xml b/addons/sale/views/sale_views.xml
index f2e74fee747..c3ac5ec6e64 100644
--- a/addons/sale/views/sale_views.xml
+++ b/addons/sale/views/sale_views.xml
@@ -254,8 +254,16 @@
                             string="Void Transaction"
                             confirm="Are you sure you want to void the authorized transaction? This action can't be undone."
                             attrs="{'invisible': [('authorized_transaction_ids', '=', [])]}"/>
+                    <button name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
+                        type="action" class="btn-primary"
+                        attrs="{'invisible': [('invoice_status', '!=', 'to invoice')]}"/>
+                    <button name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
+                        type="action" context="{'default_advance_payment_method': 'percentage'}"
+                        attrs="{'invisible': ['|',('invoice_status', '!=', 'no'), ('state', '!=', 'sale')]}"/>
                     <button name="action_quotation_send" string="Send by Email" type="object" states="draft" class="btn-primary"/>
-                    <button name="action_quotation_send" type="object" string="Send PRO-FORMA Invoice" groups="sale.group_proforma_sales" class="btn-primary" attrs="{'invisible': ['|', ('state', '!=', 'draft'), ('invoice_count','&gt;=',1)]}" context="{'proforma': True}"/>
+                    <button name="action_quotation_send" type="object" string="Send PRO-FORMA Invoice"
+                      groups="sale.group_proforma_sales" class="btn-primary"
+                      attrs="{'invisible': ['|', ('state', '!=', 'draft'), ('invoice_count','&gt;=',1)]}" context="{'proforma': True}"/>
                     <button name="action_confirm" id="action_confirm"
                         string="Confirm" class="btn-primary" type="object"
                         attrs="{'invisible': [('state', 'not in', ['sent'])]}"/>
@@ -625,7 +633,7 @@
                                 <group name="sale_info" string="Invoicing">
                                     <field name="fiscal_position_id" options="{'no_create': True}"/>
                                     <field name="analytic_account_id" context="{'default_partner_id':partner_invoice_id, 'default_name':name}" attrs="{'readonly': [('invoice_count','!=',0),('state','=','sale')]}" groups="analytic.group_analytic_accounting" force_save="1"/>
-                                    <field name="invoice_status" states="sale,done" invisible="1"/>
+                                    <field name="invoice_status" states="sale,done"/>
                                 </group>
                             </group>
                             <group>
diff --git a/addons/sale_management/views/sale_management_views.xml b/addons/sale_management/views/sale_management_views.xml
index d0f298f8055..6b838a04e0f 100644
--- a/addons/sale_management/views/sale_management_views.xml
+++ b/addons/sale_management/views/sale_management_views.xml
@@ -52,25 +52,6 @@
         <field name="active" eval="True"/>
     </record>
 
-    <record id="sale_order_view_form" model="ir.ui.view">
-        <field name="name">sale.order.form</field>
-        <field name="model">sale.order</field>
-        <field name="inherit_id" ref="sale.view_order_form"/>
-        <field name="arch" type="xml">
-            <xpath expr="//group[@name='sale_info']/field[@name='invoice_status']" position="attributes">
-                <attribute name="invisible" eval="False"/>
-            </xpath>
-            <xpath expr="//button[@name='action_quotation_send']" position="before">
-                <button name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
-                    type="action" class="btn-primary"
-                    attrs="{'invisible': [('invoice_status', '!=', 'to invoice')]}"/>
-                <button name="%(sale.action_view_sale_advance_payment_inv)d" string="Create Invoice"
-                    type="action" context="{'default_advance_payment_method': 'percentage'}"
-                    attrs="{'invisible': ['|',('invoice_status', '!=', 'no'), ('state', '!=', 'sale')]}"/>
-            </xpath>
-        </field>
-    </record>
-
     <record id="res_config_settings_view_form_inherit_sale_management" model="ir.ui.view">
         <field name="name">res.config.settings.view.form.inherit.sale.management</field>
         <field name="model">res.config.settings</field>
@@ -82,18 +63,4 @@
         </field>
     </record>
 
-    <record model="ir.ui.view" id="product_template_sale_form_view">
-        <field name="name">product.template.sales</field>
-        <field name="model">product.template</field>
-        <field name="inherit_id" ref="product.product_template_form_view"/>
-        <field name="arch" type="xml">
-            <xpath expr="//group[@name='sale']" position="attributes">
-                <attribute name="invisible">0</attribute>
-            </xpath>
-            <xpath expr="//group[@name='invoicing']" position="attributes">
-                <attribute name="invisible">0</attribute>
-            </xpath>
-        </field>
-    </record>
-
 </odoo>