From 8fc3df9617bf6ed045f1bafb058d2deb8cfc9b93 Mon Sep 17 00:00:00 2001 From: Rahul Prajapati Date: Mon, 18 Apr 2022 09:39:43 +0000 Subject: [PATCH] [IMP] mail: remove obsolete method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit: There is a obsolete method _action_remove_members in tests which is not needed now After this commit: Removed this obsolete method Task-2824921 closes odoo/odoo#88988 Signed-off-by: Sébastien Theys (seb) --- addons/mail/models/mail_channel.py | 9 --------- addons/mail/tests/test_mail_channel.py | 5 ++++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/addons/mail/models/mail_channel.py b/addons/mail/models/mail_channel.py index ad2fe41c58c..028315f1128 100644 --- a/addons/mail/models/mail_channel.py +++ b/addons/mail/models/mail_channel.py @@ -448,15 +448,6 @@ class Channel(models.Model): current_channel_partner._rtc_invite_members(partner_ids=partners.ids, guest_ids=guests.ids) self.env['bus.bus']._sendmany(notifications) - def _action_remove_members(self, partners): - """ Private implementation to remove members from channels. Done as sudo - to avoid ACLs issues with channel partners. """ - self.env['mail.channel.partner'].sudo().search([ - ('partner_id', 'in', partners.ids), - ('channel_id', 'in', self.ids) - ]).unlink() - self.invalidate_cache(fnames=['channel_partner_ids', 'channel_last_seen_partner_ids']) - def _can_invite(self, partner_id): """Return True if the current user can invite the partner to the channel. diff --git a/addons/mail/tests/test_mail_channel.py b/addons/mail/tests/test_mail_channel.py index 8d9955099d9..d61d694b435 100644 --- a/addons/mail/tests/test_mail_channel.py +++ b/addons/mail/tests/test_mail_channel.py @@ -194,7 +194,10 @@ class TestChannelInternals(MailCommon): self.assertEqual(channel.message_partner_ids, self.env['res.partner']) self.assertEqual(channel.channel_partner_ids, self.test_partner) - channel._action_remove_members(self.test_partner) + self.env['mail.channel.partner'].sudo().search([ + ('partner_id', 'in', self.test_partner.ids), + ('channel_id', 'in', channel.ids) + ]).unlink() self.assertEqual(channel.message_partner_ids, self.env['res.partner']) self.assertEqual(channel.channel_partner_ids, self.env['res.partner'])