From 8f4c8ef2dbd6daf7bf4640a392428b43ad5090d3 Mon Sep 17 00:00:00 2001
From: wan <wan@odoo.com>
Date: Tue, 13 Aug 2019 09:22:20 +0000
Subject: [PATCH] [IMP] account: add the ability to exclude from journal groups
 Task 2034896

* Change the logic from selecting journals to include, to journals to exclude
* Add a placeholder for the account.journal.group name
* Rename the field name for back-to-basics

closes odoo/odoo#34779

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
---
 addons/account/models/account.py      |  4 ++--
 addons/account/views/account_view.xml | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/addons/account/models/account.py b/addons/account/models/account.py
index 9f211193ee2..143ca388763 100644
--- a/addons/account/models/account.py
+++ b/addons/account/models/account.py
@@ -546,9 +546,9 @@ class AccountJournalGroup(models.Model):
     _name = 'account.journal.group'
     _description = "Account Journal Group"
 
-    name = fields.Char("Group Name", required=True, translate=True)
+    name = fields.Char("Journal Group", required=True, translate=True)
     company_id = fields.Many2one('res.company', required=True, default=lambda self: self.env.company)
-    account_journal_ids = fields.Many2many('account.journal', string="Journals", domain="[('company_id', '=', company_id)]")
+    excluded_journal_ids = fields.Many2many('account.journal', string="Excluded Journals", domain="[('company_id', '=', company_id)]")
     sequence = fields.Integer(default=10)
 
 
diff --git a/addons/account/views/account_view.xml b/addons/account/views/account_view.xml
index 3f5b4315069..608265bb51a 100644
--- a/addons/account/views/account_view.xml
+++ b/addons/account/views/account_view.xml
@@ -172,7 +172,7 @@
                 </kanban>
             </field>
         </record>
-        
+
         <record id="view_account_journal_search" model="ir.ui.view">
             <field name="name">account.journal.search</field>
             <field name="model">account.journal</field>
@@ -200,7 +200,7 @@
                 <tree editable="bottom">
                     <field name="sequence"  widget="handle"/>
                     <field name="name"/>
-                    <field name="account_journal_ids" widget="many2many_tags" options="{'no_create': True}"/>
+                    <field name="excluded_journal_ids" widget="many2many_tags" options="{'no_create': True}"/>
                     <field name="company_id" groups="base.group_multi_company"/>
                 </tree>
             </field>
@@ -214,9 +214,9 @@
                 <form string="Journal Groups">
                     <sheet>
                         <group>
-                            <field name="name"/>
-                            <field name="account_journal_ids" widget="many2many_tags" options="{'no_create': True}"/>
-                            <field name="sequence"/>
+                            <field name="name" placeholder="e.g. GAAP, IFRS, ..."/>
+                            <field name="excluded_journal_ids" widget="many2many_tags" options="{'no_create': True}"/>
+                            <field name="sequence" groups="base.group_no_one"/>
                             <field name="company_id" groups="base.group_multi_company"/>
                         </group>
                     </sheet>