From 8e80f6bece2c1064d85dbb4965041abdbc1bb61d Mon Sep 17 00:00:00 2001
From: clesgow <quwo@odoo.com>
Date: Fri, 30 Sep 2022 09:27:08 +0000
Subject: [PATCH] [IMP] stock: Storage category capacity menu

"Storage Category Capacity" menu appears as long as the debug mode is
on, even if the "Storage Category" isn't selected in the settings and
the corresponding group isn't set.

Since this menu is accessible from the Storage Category form anyway, we
move the link to this table in the settings (where we can safely display
it in debug AND with the setting activated), and we remove it from the
menu.

Part of task-2985735

closes odoo/odoo#102422

X-original-commit: 8b2ca9743af423dbe89c4992f462d36d434a60a9
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
---
 addons/stock/i18n/stock.pot                         | 2 +-
 addons/stock/views/res_config_settings_views.xml    | 7 +++++--
 addons/stock/views/stock_storage_category_views.xml | 1 -
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/addons/stock/i18n/stock.pot b/addons/stock/i18n/stock.pot
index 736c57b0a53..629fc7599e9 100644
--- a/addons/stock/i18n/stock.pot
+++ b/addons/stock/i18n/stock.pot
@@ -7490,8 +7490,8 @@ msgstr ""
 #: model:ir.model,name:stock.model_stock_storage_category_capacity
 #: model:ir.model.fields,field_description:stock.field_product_product__storage_category_capacity_ids
 #: model:ir.model.fields,field_description:stock.field_stock_package_type__storage_category_capacity_ids
-#: model:ir.ui.menu,name:stock.menu_storage_categoty_capacity_config
 #: model_terms:ir.ui.view,arch_db:stock.stock_storage_category_capacity_tree
+#: model_terms:ir.ui.view,arch_db:stock.res_config_settings_view_form
 msgid "Storage Category Capacity"
 msgstr ""
 
diff --git a/addons/stock/views/res_config_settings_views.xml b/addons/stock/views/res_config_settings_views.xml
index 3287a69b263..4e43367f592 100644
--- a/addons/stock/views/res_config_settings_views.xml
+++ b/addons/stock/views/res_config_settings_views.xml
@@ -445,10 +445,13 @@
                                     <div class="text-muted">
                                         Categorize your locations for smarter putaway rules
                                     </div>
-                                    <div class="content-group">
-                                        <div class="mt8" attrs="{'invisible': [('group_stock_storage_categories', '=', False)]}">
+                                    <div class="content-group" attrs="{'invisible': [('group_stock_storage_categories', '=', False)]}">
+                                        <div class="mt8">
                                             <button name="%(stock.action_storage_category)d" icon="fa-arrow-right" type="action" string="Storage Categories" class="btn-link"/>
                                         </div>
+                                        <div class="mt4" groups="base.group_no_one">
+                                            <button name="%(stock.action_storage_category_capacity)d" icon="fa-arrow-right" type="action" string="Storage Category Capacity" class="btn-link"/>
+                                        </div>
                                     </div>
                                 </div>
                             </div>
diff --git a/addons/stock/views/stock_storage_category_views.xml b/addons/stock/views/stock_storage_category_views.xml
index af73e63ca6f..e6d39c9af1d 100644
--- a/addons/stock/views/stock_storage_category_views.xml
+++ b/addons/stock/views/stock_storage_category_views.xml
@@ -100,6 +100,5 @@
     </record>
 
     <menuitem id="menu_storage_categoty_config" action="action_storage_category" name="Storage Categories" parent="menu_warehouse_config" sequence="6" groups="stock.group_stock_storage_categories"/>
-    <menuitem id="menu_storage_categoty_capacity_config" action="action_storage_category_capacity" name="Storage Category Capacity" parent="menu_warehouse_config" sequence="7" groups="base.group_no_one"/>
 
 </odoo>