From 8da2d4a092ad1789cc117abf3239f44c8c806e6f Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Tue, 5 Mar 2024 10:24:28 +0000 Subject: [PATCH] [FIX] website_forum: redirect /forum/x/question/y simplify MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Don't try to keep extra params and co. Keep it simple... Else we should pop from request.params `forum` and `post` keys because now they are converted as query param with the slug format: /forum/help-1/question-1?forum=forum.forum(1,)&question=forum.post(1,) closes odoo/odoo#156910 X-original-commit: b62bd391ccf754da9411ca5e8bff9cfafeed2a66 Signed-off-by: Jérémy Kersten --- addons/website_forum/controllers/website_forum.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/addons/website_forum/controllers/website_forum.py b/addons/website_forum/controllers/website_forum.py index db3a448e640..5a6acc1d420 100644 --- a/addons/website_forum/controllers/website_forum.py +++ b/addons/website_forum/controllers/website_forum.py @@ -11,7 +11,6 @@ import werkzeug.wrappers from odoo import _, http, tools from odoo.addons.http_routing.models.ir_http import slug -from odoo.addons.portal.controllers.portal import _build_url_w_params from odoo.addons.website.models.ir_http import sitemap_qs2dom from odoo.addons.website_profile.controllers.main import WebsiteProfile from odoo.exceptions import AccessError, UserError @@ -281,7 +280,7 @@ class WebsiteForum(WebsiteProfile): type='http', auth="public", website=True, sitemap=False) def old_question(self, forum, question, **post): # Compatibility pre-v14 - return request.redirect(_build_url_w_params("/forum/%s/%s" % (slug(forum), slug(question)), request.params), code=301) + return request.redirect("/forum/%s/%s" % (slug(forum), slug(question)), code=301) def sitemap_forum_post(env, rule, qs): ForumPost = env['forum.post']