From 8ccba2ce155ab6d0b40308fca144f2800fc98027 Mon Sep 17 00:00:00 2001
From: Mitali Patel <mpa@odoo.com>
Date: Mon, 5 Jul 2021 13:21:17 +0000
Subject: [PATCH] [IMP] project, hr_timesheet: improve customer rating on
 project

Purpose of the commit is to improve the customer rating report
of the project app.

So in this commit, done the below changes:

- remove the project and task measures
- switch the rating value and the count from place in pivot view
- remove the default group by rated operator, keep it fot grap view
- reorder the some fields on form and list view
- use the badge widget for the rating field and the color code is applied to the form view
- add some demo data for the feedback field in list view
- center the information vertically in kanban view
- move the 'customer ratings' menu item below the 'project costs and revenues' one
- add the following filters: My Projects, My Team
  - reorder the group bys and rename 'Resource' into 'Task'
  - reorder the search fields
- project kanban card
  - the ratings % is represent the average satisfaction rate of the ratings submitted in the last 30 days (including today)
  - change the tooltip to: Average satisfaction rate for the last 30 days
- the 'customer satisfaction' stat button display the last 30 days rating on the project.project
and this stat button should open the kanban view by default instead of the list view

task-2531428
closes #73581
---
 addons/project/data/project_demo.xml   |  6 ++--
 addons/project/views/project_views.xml |  6 ++--
 addons/project/views/rating_views.xml  | 38 ++++++++++++++++++++++++--
 3 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/addons/project/data/project_demo.xml b/addons/project/data/project_demo.xml
index 5a28c0ebdc6..043938e9641 100644
--- a/addons/project/data/project_demo.xml
+++ b/addons/project/data/project_demo.xml
@@ -906,9 +906,9 @@ Send it ASAP, its urgent.</field>
             <field name="rating_template_id" ref="rating_project_request_email_template"/>
         </record>
 
-        <function model="project.task" name="rating_apply" eval="([ref('project.project_task_3')], 5)"/>
-        <function model="project.task" name="rating_apply" eval="([ref('project.project_task_24')], 5)"/>
-        <function model="project.task" name="rating_apply" eval="([ref('project.project_task_8')], 1)"/>
+        <function model="project.task" name="rating_apply" eval="([ref('project.project_task_3')], 5, None, 'Good Job')"/>
+        <function model="project.task" name="rating_apply" eval="([ref('project.project_task_24')], 5, None, 'Great work')"/>
+        <function model="project.task" name="rating_apply" eval="([ref('project.project_task_8')], 1, None, 'Not as good as expected')"/>
 
         <record id="project_milestone_1" model="project.milestone">
             <field name="is_reached" eval="True"/>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 3b802f21ad0..c81a5cc9545 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -658,10 +658,10 @@
                                                 <div t-if="record.alias_name.value and record.alias_domain.value" class="text-muted">
                                                     <span class="fa fa-envelope-o mr-2" aria-label="Domain Alias" title="Domain Alias"></span><t t-esc="record.alias_id.value"/>
                                                 </div>
-                                                <div t-if="record.rating_active.raw_value" class="text-muted" title="Percentage of happy ratings over the past 30 days." groups="project.group_project_rating">
+                                                <div t-if="record.rating_active.raw_value" class="text-muted" groups="project.group_project_rating">
                                                     <b>
                                                         <t t-if="record.rating_percentage_satisfaction.value != -1">
-                                                            <i class="fa fa-smile-o" role="img" aria-label="Percentage of satisfaction" title="Percentage of satisfaction"/> <t t-esc="record.rating_percentage_satisfaction.value"/>%
+                                                            <i class="fa fa-smile-o" role="img" aria-label="Average satisfaction rate for the last 30 days." title="Average satisfaction rate for the last 30 days."/> <t t-esc="record.rating_percentage_satisfaction.value"/>%
                                                         </t>
                                                     </b>
                                                 </div>
@@ -1436,7 +1436,7 @@
             action="rating_rating_action_project_report"
             parent="menu_project_report"
             groups="project.group_project_rating"
-            sequence="40"/>
+            sequence="51"/>
 
         <record id="project_view_kanban_inherit_project" model="ir.ui.view">
             <field name="name">project.kanban.inherit.project</field>
diff --git a/addons/project/views/rating_views.xml b/addons/project/views/rating_views.xml
index 7cf215b7c8a..4250fab7e5f 100644
--- a/addons/project/views/rating_views.xml
+++ b/addons/project/views/rating_views.xml
@@ -24,6 +24,13 @@
         <field name="inherit_id" ref="rating.rating_rating_view_form"/>
         <field name="mode">primary</field>
         <field name="arch" type="xml">
+            <xpath expr="//form" position="attributes">
+                <attribute name="edit">0</attribute>
+            </xpath>
+            <field name="resource_ref" position="before">
+                <field name="rated_partner_id" position="move"/>
+                <field name="parent_ref" position="move"/>
+            </field>
             <field name="res_name" position="attributes">
                 <attribute name="string">Task</attribute>
             </field>
@@ -46,8 +53,11 @@
                 <attribute name="readonly">1</attribute>
             </field>
             <div name="rating_image_container" position="replace">
-                <field name="rating_text" string="Rating"/>
+                <field name="rating_text" string="Rating" decoration-danger="rating_text == 'ko'" decoration-warning="rating_text == 'ok'" decoration-success="rating_text == 'top'" widget='badge'/>
             </div>
+            <field name="create_date" position="after">
+                <field name="partner_id" position="move"/>
+            </field>
             <xpath expr="//field[@name='is_internal']" position="attributes">
                 <attribute name="invisible">1</attribute>
             </xpath>
@@ -63,6 +73,9 @@
             <xpath expr="//pivot" position="attributes">
                 <attribute name="js_class">project_rating_pivot</attribute>
             </xpath>
+            <xpath expr="//field[@name='create_date']" position="attributes">
+                <attribute name="invisible">1</attribute>
+            </xpath>
         </field>
     </record>
 
@@ -84,8 +97,24 @@
         <field name="inherit_id" ref="rating.rating_rating_view_search"/>
         <field name="mode">primary</field>
         <field name="arch" type="xml">
-            <xpath expr="//filter[@name='resource']" position="after">
+            <xpath expr="//field[@name='rated_partner_id']" position="after">
+                <field name="parent_res_name" position="move"/>
+                <field name="res_name" position="move"/>
+            </xpath>
+            <xpath expr="//field[@name='parent_res_name']" position="attributes">
+                <attribute name="string">Project</attribute>
+            </xpath>
+            <xpath expr="//field[@name='res_name']" position="attributes">
+                <attribute name="string">Task</attribute>
+            </xpath>
+            <xpath expr="//filter[@name='responsible']" position="after">
+                <filter name="rating_text" position="move"/>
                 <filter string="Project" name="groupby_project" context="{'group_by': 'parent_res_name'}"/>
+                <filter name="resource" position="move"/>
+                <filter name="customer" position="move"/>
+            </xpath>
+            <xpath expr="//filter[@name='resource']" position="attributes">
+                <attribute name="string">Task</attribute>
             </xpath>
             <xpath expr="//filter[@name='responsible']" position="replace"></xpath>
             <xpath expr="/search" position="inside">
@@ -208,7 +237,10 @@
                 Let's wait for your customers to manifest themselves.
             </p>
         </field>
-        <field name="context">{'search_default_rating_last_30_days': 1, 'search_default_responsible': 1}</field>
+        <field name="context">{
+            'search_default_rating_last_30_days': 1,
+            'graph_groupbys': ['rated_partner_id'],
+        }</field>
     </record>
 
     <record id="rating_rating_action_project_report_kanban" model="ir.actions.act_window.view">