From 8b94bf8b28ea43c5d49fc058f6f496dc90c47fe5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A9ry=20Debongnie?= Date: Sun, 21 May 2017 22:19:58 +0200 Subject: [PATCH] [FIX] web: form: remove o_field_invalid class when not necessary Before this commit, the o_field_invalid class was not removed once an invalid field becomes valid, until the user saves the form view (which will rerender the full view anyway) --- addons/web/static/src/js/views/form/form_renderer.js | 3 +++ addons/web/static/tests/views/form_tests.js | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web/static/src/js/views/form/form_renderer.js b/addons/web/static/src/js/views/form/form_renderer.js index c96a513ab03..3747699f45c 100644 --- a/addons/web/static/src/js/views/form/form_renderer.js +++ b/addons/web/static/src/js/views/form/form_renderer.js @@ -84,6 +84,9 @@ var FormRenderer = BasicRenderer.extend({ _.each(resetWidgets, function (widget) { self._setIDForLabel(widget, self.idsForLabels[widget.name]); }); + if (self.$('.o_field_invalid').length) { + self.canBeSaved(self.state.id); + } return resetWidgets; }); }, diff --git a/addons/web/static/tests/views/form_tests.js b/addons/web/static/tests/views/form_tests.js index e034b599077..646de772b4e 100644 --- a/addons/web/static/tests/views/form_tests.js +++ b/addons/web/static/tests/views/form_tests.js @@ -2273,7 +2273,6 @@ QUnit.module('Views', { "input should be tagged as invalid"); form.$('input').val("tralala").trigger('input'); - form.$buttons.find('.o_form_button_save').click(); assert.strictEqual(form.$('.o_field_invalid').length, 0, "nothing should be marked as invalid");