From 8b91cab67f122667ecc250a8b016b152929c61e2 Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Wed, 18 May 2022 13:30:12 +0000 Subject: [PATCH] [IMP] base: remove groups_id from ir.ui.view The goal of this revision is to get rid of the `groups_id` field of the model `ir.ui.view`. - This feature wasn't really known or used by most developers, and not straight-forward to understand. Removing it allows one less complicated thing to learn for developers. Besides, thanks to odoo/odoo#95729, changing the behavior of the `groups=` attribute, we can easily get rid of this `groups_id` feature by simply adding `groups=` in the elements of the views using the `groups_id` field, it will have the same effect: adding the elements in the view only for the users part of the specified group. - By getting rid of the groups_id many2many field on ir.ui.view, it makes possible to cache the view architecture without requiring to use the groups in the cache key. Currently, if we want to cache the view architecture, it would be required to use the intersection of the user groups with the groups_id groups of the view, making it costly to compute the cache key, therefore altering the performance point to cache the view architectures. Part-of: odoo/odoo#98551 --- .../report/account_invoice_report_view.xml | 3 +- addons/account/views/partner_view.xml | 17 +- .../views/res_config_settings_views.xml | 3 +- .../crm/views/res_config_settings_views.xml | 1 - addons/crm/views/res_partner_views.xml | 4 +- .../event/views/res_config_settings_views.xml | 1 - addons/event/views/res_partner_views.xml | 1 - .../fleet/views/res_config_settings_views.xml | 1 - addons/hr/views/res_config_settings_views.xml | 1 - .../views/hr_department_view.xml | 3 +- .../views/res_config_settings_views.xml | 1 - .../hr_expense/views/hr_department_views.xml | 7 +- .../views/res_config_settings_views.xml | 1 - addons/hr_holidays/views/hr_views.xml | 55 ++++--- .../hr_presence/views/hr_employee_views.xml | 3 +- .../views/hr_department_views.xml | 26 +-- .../views/res_config_settings_views.xml | 1 - addons/hr_timesheet/views/hr_views.xml | 5 +- addons/hr_timesheet/views/project_views.xml | 37 ++--- .../views/res_config_settings_views.xml | 1 - addons/lunch/views/res_config_settings.xml | 1 - .../views/res_config_settings_views.xml | 1 - addons/mrp/views/product_views.xml | 8 +- .../mrp/views/res_config_settings_views.xml | 1 - .../views/analytic_account_views.xml | 3 +- .../views/mrp_production_views.xml | 27 ++-- addons/mrp_account/views/product_views.xml | 38 +++-- .../views/product_views.xml | 3 +- .../views/res_partner_views.xml | 5 +- .../views/stock_quant_views.xml | 3 +- .../views/res_config_settings_views.xml | 19 +-- .../point_of_sale/views/res_partner_view.xml | 8 +- addons/pos_sale/views/sales_team_views.xml | 3 +- addons/product/views/res_partner_views.xml | 1 - .../views/res_config_settings_views.xml | 1 - addons/project/views/res_partner_views.xml | 2 +- addons/purchase/views/product_views.xml | 4 +- .../views/res_config_settings_views.xml | 1 - addons/purchase/views/res_partner_views.xml | 23 +-- addons/sale/views/product_views.xml | 26 +-- .../sale/views/res_config_settings_views.xml | 1 - addons/sale/views/res_partner_views.xml | 7 +- addons/sale/views/sale_order_views.xml | 15 +- .../views/hr_timesheet_views.xml | 14 +- .../views/project_task_views.xml | 11 +- addons/stock/views/product_views.xml | 149 +++++++++--------- .../stock/views/res_config_settings_views.xml | 1 - .../views/account_move_views.xml | 27 ++-- addons/survey/views/res_partner_views.xml | 3 +- .../views/res_config_settings_views.xml | 1 - .../views/res_config_settings_views.xml | 5 +- .../views/res_partner_views.xml | 3 +- odoo/addons/base/tests/test_res_config.py | 3 +- 53 files changed, 297 insertions(+), 293 deletions(-) diff --git a/addons/account/report/account_invoice_report_view.xml b/addons/account/report/account_invoice_report_view.xml index d9568556e36..51f1724a991 100644 --- a/addons/account/report/account_invoice_report_view.xml +++ b/addons/account/report/account_invoice_report_view.xml @@ -132,10 +132,9 @@ account.invoice.report.search_analytic_accounting account.invoice.report - - + diff --git a/addons/account/views/partner_view.xml b/addons/account/views/partner_view.xml index 066d609df37..7673fbad47a 100644 --- a/addons/account/views/partner_view.xml +++ b/addons/account/views/partner_view.xml @@ -142,10 +142,10 @@ res.partner -
diff --git a/addons/mrp_account/views/mrp_production_views.xml b/addons/mrp_account/views/mrp_production_views.xml index dbb7d59c67c..d0602fb8b8c 100644 --- a/addons/mrp_account/views/mrp_production_views.xml +++ b/addons/mrp_account/views/mrp_production_views.xml @@ -14,24 +14,27 @@ mrp.production.view.inherited mrp.production - - + -
- + @@ -27,13 +27,13 @@ res.partner.pos.kanban.inherit res.partner - - + diff --git a/addons/pos_sale/views/sales_team_views.xml b/addons/pos_sale/views/sales_team_views.xml index 13f7420efe9..1adf3490e0c 100644 --- a/addons/pos_sale/views/sales_team_views.xml +++ b/addons/pos_sale/views/sales_team_views.xml @@ -34,11 +34,10 @@ crm.team.view.kanban.dashboard.inherit.pos crm.team - -
+
diff --git a/addons/product/views/res_partner_views.xml b/addons/product/views/res_partner_views.xml index 98c37975d44..be679618a77 100644 --- a/addons/product/views/res_partner_views.xml +++ b/addons/product/views/res_partner_views.xml @@ -4,7 +4,6 @@ res.partner.product.property.form.inherit res.partner - diff --git a/addons/project/views/res_config_settings_views.xml b/addons/project/views/res_config_settings_views.xml index a21bf9a2a4c..1c607bd462f 100644 --- a/addons/project/views/res_config_settings_views.xml +++ b/addons/project/views/res_config_settings_views.xml @@ -5,7 +5,6 @@ res.config.settings -
diff --git a/addons/project/views/res_partner_views.xml b/addons/project/views/res_partner_views.xml index 1568dc4d60f..df06edceaf1 100644 --- a/addons/project/views/res_partner_views.xml +++ b/addons/project/views/res_partner_views.xml @@ -7,10 +7,10 @@ res.partner -
- - - - - + + + + + + + @@ -112,10 +113,10 @@ res.partner -
diff --git a/addons/sale/views/product_views.xml b/addons/sale/views/product_views.xml index faceb3fe9d5..4ed777931cb 100644 --- a/addons/sale/views/product_views.xml +++ b/addons/sale/views/product_views.xml @@ -39,7 +39,6 @@ product.product.sale.order product.product -
- - - - + + + + + +
@@ -72,7 +73,6 @@ product.template.sale.order.button product.template -
- - - - + + + + + +
diff --git a/addons/sale/views/res_config_settings_views.xml b/addons/sale/views/res_config_settings_views.xml index a6730e97153..512124abfb1 100644 --- a/addons/sale/views/res_config_settings_views.xml +++ b/addons/sale/views/res_config_settings_views.xml @@ -6,7 +6,6 @@ res.config.settings -
res.partner - - + @@ -43,7 +43,6 @@ res.partner -
- + sale.order.form sale.order - diff --git a/addons/sale_timesheet/views/hr_timesheet_views.xml b/addons/sale_timesheet/views/hr_timesheet_views.xml index 5258506112d..35cfc569804 100644 --- a/addons/sale_timesheet/views/hr_timesheet_views.xml +++ b/addons/sale_timesheet/views/hr_timesheet_views.xml @@ -39,13 +39,12 @@ account.analytic.line.tree.inherit account.analytic.line - - - - + + + @@ -53,13 +52,12 @@ account.analytic.line.form.inherit account.analytic.line - - - - + + + diff --git a/addons/sale_timesheet/views/project_task_views.xml b/addons/sale_timesheet/views/project_task_views.xml index 2835d907428..c2f38bebd29 100644 --- a/addons/sale_timesheet/views/project_task_views.xml +++ b/addons/sale_timesheet/views/project_task_views.xml @@ -117,17 +117,16 @@ sale.service.form.view.inherit project.task - - + - - + + - - + + diff --git a/addons/stock/views/product_views.xml b/addons/stock/views/product_views.xml index f4c7cb8c3fb..4c032b23fb6 100644 --- a/addons/stock/views/product_views.xml +++ b/addons/stock/views/product_views.xml @@ -236,7 +236,6 @@ product.product.procurement product.product - @@ -252,82 +251,84 @@ attrs="{'invisible': [('type', 'not in', ['consu', 'product'])]}"/>
- - - - + - - - - -
+ + + + +
diff --git a/addons/stock/views/res_config_settings_views.xml b/addons/stock/views/res_config_settings_views.xml index 6f24ccf7bc0..a80aff865d0 100644 --- a/addons/stock/views/res_config_settings_views.xml +++ b/addons/stock/views/res_config_settings_views.xml @@ -6,7 +6,6 @@ res.config.settings -
diff --git a/addons/stock_landed_costs/views/account_move_views.xml b/addons/stock_landed_costs/views/account_move_views.xml index de3c3717574..cd0bab01772 100644 --- a/addons/stock_landed_costs/views/account_move_views.xml +++ b/addons/stock_landed_costs/views/account_move_views.xml @@ -4,29 +4,32 @@ account.view.move.form.inherited account.move - - -