From 8b7861ddabf92f85aff7665cb5bd79922676f545 Mon Sep 17 00:00:00 2001
From: "Nicolas (vin)" <vin@odoo.com>
Date: Thu, 23 Jul 2020 12:50:49 +0000
Subject: [PATCH] [IMP] account: Clean various feedbacks reported by
 consultants

Clean various feedbacks reported by consultants WTA/CTH.

It concerns namely :
- CoA
- DEMO DATA
- SEQUENCE NUMBER ON JOURNALS
- PAYMENT STATUS
- BANK STATEMENTS

Task ID: #2300936

closes odoo/odoo#54874

Related: odoo/enterprise#11995
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
---
 addons/account/models/account_account.py           | 2 +-
 addons/account/views/account_account_views.xml     | 1 +
 addons/account/views/account_move_views.xml        | 2 +-
 addons/account/wizard/account_resequence_views.xml | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/addons/account/models/account_account.py b/addons/account/models/account_account.py
index b7da1a1ac37..f7497fcaf8a 100644
--- a/addons/account/models/account_account.py
+++ b/addons/account/models/account_account.py
@@ -76,7 +76,7 @@ class AccountAccount(models.Model):
     company_id = fields.Many2one('res.company', string='Company', required=True, readonly=True,
         default=lambda self: self.env.company)
     tag_ids = fields.Many2many('account.account.tag', 'account_account_account_tag', string='Tags', help="Optional tags you may want to assign for custom reporting")
-    group_id = fields.Many2one('account.group', compute='_compute_account_group', store=True)
+    group_id = fields.Many2one('account.group', compute='_compute_account_group', store=True, readonly=False)
     root_id = fields.Many2one('account.root', compute='_compute_account_root', store=True)
     allowed_journal_ids = fields.Many2many('account.journal', string="Allowed Journals", help="Define in which journals this account can be used. If empty, can be used in all journals.")
 
diff --git a/addons/account/views/account_account_views.xml b/addons/account/views/account_account_views.xml
index 62b6b91308c..73b6a807f26 100644
--- a/addons/account/views/account_account_views.xml
+++ b/addons/account/views/account_account_views.xml
@@ -27,6 +27,7 @@
                            <group name="left_main_group">
                              <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                              <field name="user_type_id" widget="account_hierarchy_selection"/>
+                             <field name="group_id"/>
                              <field name="internal_type" invisible="1" readonly="1"/>
                              <field name="internal_group" invisible="1" readonly="1"/>
                            </group>
diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 88716292776..18aa8075699 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -428,7 +428,7 @@
                     <field name="currency_id" invisible="1"/>
                     <field name="company_currency_id" invisible="1"/>
                     <field name="state" widget="badge" decoration-success="state == 'posted'" decoration-info="state == 'draft'" optional="show"/>
-                    <field name="payment_state" widget="badge" decoration-warning="payment_state in ('partial', 'in_payment')" decoration-success="payment_state in ('paid', 'reversed')" attrs="{'invisible': [('payment_state', 'in', ('not_paid', 'invoicing_legacy'))]}" nolabel="1"/>
+                    <field name="payment_state" widget="badge" decoration-danger="payment_state in ('not_paid')"  decoration-warning="payment_state in ('partial', 'in_payment')" decoration-success="payment_state in ('paid', 'reversed')" attrs="{'invisible': [('payment_state', 'in', ('invoicing_legacy'))]}"/>
                     <field name="move_type" invisible="context.get('default_move_type', True)"/>
                   </tree>
             </field>
diff --git a/addons/account/wizard/account_resequence_views.xml b/addons/account/wizard/account_resequence_views.xml
index 853c0240ae8..c1d5cb1529c 100644
--- a/addons/account/wizard/account_resequence_views.xml
+++ b/addons/account/wizard/account_resequence_views.xml
@@ -33,7 +33,7 @@
             <field name="view_mode">form</field>
             <field name="view_id" ref="account_resequence_view"/>
             <field name="target">new</field>
-            <field name="groups_id" eval="[(4, ref('base.group_no_one'))]"/>
+            <field name="groups_id" eval="[(6, 0, [ref('account.group_account_manager'), ref('base.group_system')])]"/>
             <field name="binding_model_id" ref="account.model_account_move" />
             <field name="binding_view_types">list</field>
         </record>