From 8b5f022a51941b445078e505e501d61e7727996a Mon Sep 17 00:00:00 2001
From: "Louis Wicket (wil)" <wil@odoo.com>
Date: Mon, 24 Jul 2023 10:12:04 +0000
Subject: [PATCH] [IMP] mail: don't convert iterables to arrays in t-foreach

As of Owl 2.2, it is now possible to use iterable directly in t-foreach
without having to convert it to array first.

This commit takes advantage of this new feature to remove the
unnecessary array conversions from the Discuss code.

closes odoo/odoo#129765

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
---
 addons/mail/static/src/core/web/follower_list.xml             | 2 +-
 addons/mail/static/src/core/web/recipient_list.xml            | 2 +-
 addons/mail/static/src/discuss/call/common/call.js            | 4 ----
 addons/mail/static/src/discuss/call/common/call.xml           | 2 +-
 .../mail/static/src/discuss/gif_picker/common/gif_picker.xml  | 2 +-
 5 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/addons/mail/static/src/core/web/follower_list.xml b/addons/mail/static/src/core/web/follower_list.xml
index 026346f2504..a6e9576ea97 100644
--- a/addons/mail/static/src/core/web/follower_list.xml
+++ b/addons/mail/static/src/core/web/follower_list.xml
@@ -15,7 +15,7 @@
         <div t-if="props.thread.followers.size > 0" role="separator" class="dropdown-divider"/>
     </t>
     <t t-if="props.thread.followers.size > 0">
-        <t t-foreach="[...props.thread.followers]" t-as="follower" t-key="follower.id">
+        <t t-foreach="props.thread.followers" t-as="follower" t-key="follower.id">
             <t t-call="mail.Follower">
                 <t t-set="follower" t-value="follower"/>
             </t>
diff --git a/addons/mail/static/src/core/web/recipient_list.xml b/addons/mail/static/src/core/web/recipient_list.xml
index c31cfa7aa03..56ed55607ed 100644
--- a/addons/mail/static/src/core/web/recipient_list.xml
+++ b/addons/mail/static/src/core/web/recipient_list.xml
@@ -5,7 +5,7 @@
         <div class="o-mail-RecipientList p-2 overflow-auto">
             <ul class="list-unstyled mb-0">
                 <li t-if="props.thread.selfFollower" t-out="props.thread.selfFollower.partner.email"/>
-                <li t-foreach="[...props.thread.followers]" t-as="follower" t-key="follower.id">
+                <li t-foreach="props.thread.followers" t-as="follower" t-key="follower.id">
                     <t t-out="follower.partner.email"/>
                 </li>
                 <span t-if="!props.thread.followersFullyLoaded" class="btn btn-link w-100" t-on-click="() => threadService.loadMoreFollowers(props.thread)" t-ref="load-more">Load more</span>
diff --git a/addons/mail/static/src/discuss/call/common/call.js b/addons/mail/static/src/discuss/call/common/call.js
index f4557123818..937ac132bbf 100644
--- a/addons/mail/static/src/discuss/call/common/call.js
+++ b/addons/mail/static/src/discuss/call/common/call.js
@@ -55,10 +55,6 @@ export class Call extends Component {
         useExternalListener(browser, "fullscreenchange", this.onFullScreenChange);
     }
 
-    get callNotifications() {
-        return [...this.rtc.notifications.values()];
-    }
-
     get isActiveCall() {
         return Boolean(this.props.thread.id === this.rtc.state?.channel?.id);
     }
diff --git a/addons/mail/static/src/discuss/call/common/call.xml b/addons/mail/static/src/discuss/call/common/call.xml
index 7d721effc0c..3f84fccd86e 100644
--- a/addons/mail/static/src/discuss/call/common/call.xml
+++ b/addons/mail/static/src/discuss/call/common/call.xml
@@ -30,7 +30,7 @@
                     </div>
                 </div>
                 <div t-if="hasCallNotifications" class="position-absolute d-flex flex-column-reverse start-0 bottom-0" t-att-class="{ 'ps-5 pb-5': state.isFullscreen, 'ps-2 pb-2': !state.isFullscreen }">
-                    <span class="text-bg-800 shadow-lg rounded-1 m-1" t-att-class="{ 'p-4 fs-4': state.isFullscreen, 'p-2': !state.isFullscreen }" t-foreach="callNotifications" t-as="notification" t-key="notification.id" t-esc="notification.text"/>
+                    <span class="text-bg-800 shadow-lg rounded-1 m-1" t-att-class="{ 'p-4 fs-4': state.isFullscreen, 'p-2': !state.isFullscreen }" t-foreach="rtc.notifications.values()" t-as="notification" t-key="notification.id" t-esc="notification.text"/>
                 </div>
             </div>
             <div t-if="state.sidebar and props.thread.activeRtcSession" class="o-discuss-Call-sidebar d-flex align-items-center h-100 flex-column">
diff --git a/addons/mail/static/src/discuss/gif_picker/common/gif_picker.xml b/addons/mail/static/src/discuss/gif_picker/common/gif_picker.xml
index dbd9aeea52d..d72a7ecb6cf 100644
--- a/addons/mail/static/src/discuss/gif_picker/common/gif_picker.xml
+++ b/addons/mail/static/src/discuss/gif_picker/common/gif_picker.xml
@@ -28,7 +28,7 @@
                         </div>
                     </div>
                     <t t-if="state.categories.length === 0">
-                        <t t-foreach="[...Array(10).keys()]" t-as="category" t-key="category_index">
+                        <t t-foreach="Array(10).keys()" t-as="category" t-key="category_index">
                             <div class="col">
                                 <div class="position-relative ratio ratio-16x9 cursor-pointer" aria-label="list-item">
                                     <div class="position-absolute w-100 h-100 top-0 start-0 text-center o-text-white align-middle fs-2 o-bg-black bg-opacity-50"/>