From 8aa43bd7e5c1ae626a53efc60e13f95ebfb97a75 Mon Sep 17 00:00:00 2001 From: niyasraphy Date: Sat, 22 Oct 2022 07:57:28 +0000 Subject: [PATCH] [FIX] mass_mailing: do not crash when importing a void contact list Mass mailing has a wizard to import contacts from a text input. It currently crashes when trying to import a void field, while it should not. We fix that by two means * make field required in view (as model cannot be modified); * while it is not updated, simply consider a void input should not crash and is considered as an input without valid input found; Task-3053031 closes odoo/odoo#104769 X-original-commit: aa183fa29d609d2b608fa451ee48a35e3d1549b2 Signed-off-by: Thibault Delavallee (tde) --- addons/mass_mailing/wizard/mailing_contact_import.py | 3 +-- addons/mass_mailing/wizard/mailing_contact_import_views.xml | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/mass_mailing/wizard/mailing_contact_import.py b/addons/mass_mailing/wizard/mailing_contact_import.py index faeac46c2ee..33693f4fbda 100644 --- a/addons/mass_mailing/wizard/mailing_contact_import.py +++ b/addons/mass_mailing/wizard/mailing_contact_import.py @@ -15,8 +15,7 @@ class MailingContactImport(models.TransientModel): def action_import(self): """Import each lines of "contact_list" as a new contact.""" self.ensure_one() - - contacts = tools.email_split_tuples(', '.join(self.contact_list.splitlines())) + contacts = tools.email_split_tuples(', '.join((self.contact_list or '').splitlines())) if not contacts: return { 'type': 'ir.actions.client', diff --git a/addons/mass_mailing/wizard/mailing_contact_import_views.xml b/addons/mass_mailing/wizard/mailing_contact_import_views.xml index e8cc87eee7c..20abf0be4dc 100644 --- a/addons/mass_mailing/wizard/mailing_contact_import_views.xml +++ b/addons/mass_mailing/wizard/mailing_contact_import_views.xml @@ -17,6 +17,7 @@

Want to import country, company name and more?