From 8a1302a5021ad7cd754fdc24e33cbd96f9e85dd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Voet=20=28ryv=29?= Date: Fri, 28 Jan 2022 08:31:37 +0000 Subject: [PATCH] [REM] core: remove mutable default for parameters Part-of: odoo/odoo#83687 --- odoo/addons/base/models/res_users.py | 4 +++- odoo/models.py | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/odoo/addons/base/models/res_users.py b/odoo/addons/base/models/res_users.py index 6ca9bd3c1ba..e8208b11c7c 100644 --- a/odoo/addons/base/models/res_users.py +++ b/odoo/addons/base/models/res_users.py @@ -1400,7 +1400,9 @@ class UsersView(models.Model): return res @api.model - def new(self, values={}, origin=None, ref=None): + def new(self, values=None, origin=None, ref=None): + if values is None: + values = {} values = self._remove_reified_groups(values) user = super().new(values=values, origin=origin, ref=ref) group_multi_company = self.env.ref('base.group_multi_company', False) diff --git a/odoo/models.py b/odoo/models.py index f0cb0417edf..3db22c2f8d0 100644 --- a/odoo/models.py +++ b/odoo/models.py @@ -5727,7 +5727,7 @@ Fields: # @api.model - def new(self, values={}, origin=None, ref=None): + def new(self, values=None, origin=None, ref=None): """ new([values], [origin], [ref]) -> record Return a new record instance attached to the current environment and @@ -5741,6 +5741,8 @@ Fields: One can also pass a ``ref`` value to identify the record among other new records. The reference is encapsulated in the ``id`` of the record. """ + if values is None: + values = {} if origin is not None: origin = origin.id record = self.browse([NewId(origin, ref)])