From 89d50fc3b186440307d85e780e72de0b733f188d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Fri, 19 Oct 2018 13:12:06 +0000
Subject: [PATCH] [REF] utm: clean and lint views

Purpose is to give a quick polish to this module code concerning views.
Some ids are updated, indentation is fixed.

This commit is linked to task ID 1896681 and PR #27975.
---
 addons/utm/views/utm_views.xml | 218 ++++++++++++++++++---------------
 1 file changed, 122 insertions(+), 96 deletions(-)

diff --git a/addons/utm/views/utm_views.xml b/addons/utm/views/utm_views.xml
index 6e66bf89103..18852e1c270 100644
--- a/addons/utm/views/utm_views.xml
+++ b/addons/utm/views/utm_views.xml
@@ -1,110 +1,136 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-        <menuitem id="menu_link_tracker_root" name="Link Tracker" groups="base.group_no_one" sequence="30" web_icon="utm,static/description/icon.png"/>
-        <menuitem name="UTMs" id="marketing_utm" parent="menu_link_tracker_root" sequence="99" groups="base.group_no_one"/>
+    <menuitem id="menu_link_tracker_root"
+        name="Link Tracker"
+        sequence="30"
+        web_icon="utm,static/description/icon.png"
+        groups="base.group_no_one"/>
+    <menuitem id="marketing_utm"
+        name="UTMs"
+        parent="menu_link_tracker_root"
+        sequence="99"
+        groups="base.group_no_one"/>
 
-    	<!-- utm.campaign -->
-    	<record model="ir.ui.view" id="utm_campaign_tree">
-            <field name="name">utm.campaign.tree</field>
-            <field name="model">utm.campaign</field>
-            <field name="arch" type="xml">
-                <tree string="Campaign">
+	<!-- utm.campaign -->
+	<record id="utm_campaign_view_tree" model="ir.ui.view">
+        <field name="name">utm.campaign.view.tree</field>
+        <field name="model">utm.campaign</field>
+        <field name="arch" type="xml">
+            <tree string="Campaign">
+                <field name="name"/>
+            </tree>
+        </field>
+    </record>
+    <record id="utm_campaign_view_form" model="ir.ui.view">
+        <field name="name">utm.campaign.view.form</field>
+        <field name="model">utm.campaign</field>
+        <field name="arch" type="xml">
+            <form string="Campaign">
+                <group>
                     <field name="name"/>
-                </tree>
-            </field>
-        </record>
+                </group>
+            </form>
+        </field>
+    </record>
 
-        <record model="ir.ui.view" id="utm_campaign_form">
-            <field name="name">utm.campaign.form</field>
-            <field name="model">utm.campaign</field>
-            <field name="arch" type="xml">
-                <form string="Campaign">
-                    <group>
-                        <field name="name"/>
-                    </group>
-                </form>
-            </field>
-        </record>
+    <record id="utm_campaign_action" model="ir.actions.act_window">
+        <field name="name">Campaigns</field>
+        <field name="res_model">utm.campaign</field>
+        <field name="view_type">form</field>
+        <field name="view_id" ref="utm_campaign_view_tree"/>
+        <field name="help" type="html">
+            <p class="o_view_nocontent_smiling_face">
+                Define a new UTM campaign
+            </p>
+        </field>
+    </record>
 
-        <record id="utm_campaign_act" model="ir.actions.act_window">
-            <field name="name">Campaigns</field>
-            <field name="res_model">utm.campaign</field>
-            <field name="view_type">form</field>
-            <field name="view_id" ref="utm_campaign_tree"/>
-        </record>
+    <menuitem id="menu_utm_campaign_act"
+        action="utm_campaign_action"
+        parent="marketing_utm"
+        sequence="1"
+        groups="base.group_no_one"/>
 
-        <menuitem action="utm_campaign_act" id="menu_utm_campaign_act" sequence="4"
-            groups="base.group_no_one" parent="marketing_utm"/>
-
-    	<!-- utm.medium -->
-        <record id="utm_medium_view_tree" model="ir.ui.view">
-            <field name="name">utm.medium.tree</field>
-            <field name="model">utm.medium</field>
-            <field name="arch" type="xml">
-                <tree string="Medium">
+	<!-- utm.medium -->
+    <record id="utm_medium_view_tree" model="ir.ui.view">
+        <field name="name">utm.medium.view.tree</field>
+        <field name="model">utm.medium</field>
+        <field name="arch" type="xml">
+            <tree string="Mediums">
+                <field name="name"/>
+                <field name="active"/>
+            </tree>
+        </field>
+    </record>
+    <record id="utm_medium_view_form" model="ir.ui.view">
+        <field name="name">utm.medium.view.form</field>
+        <field name="model">utm.medium</field>
+        <field name="arch" type="xml">
+            <form string="Medium">
+                <group>
                     <field name="name"/>
                     <field name="active"/>
-                </tree>
-            </field>
-        </record>
-        <record id="utm_medium_view_form" model="ir.ui.view">
-            <field name="name">utm.medium.form</field>
-            <field name="model">utm.medium</field>
-            <field name="arch" type="xml">
-                <form string="Channel">
-                    <group>
-                        <field name="name"/>
-                        <field name="active"/>
-                    </group>
-                </form>
-            </field>
-        </record>
-        <record id="utm_medium_action" model="ir.actions.act_window">
-            <field name="name">Medium</field>
-            <field name="res_model">utm.medium</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">tree,form</field>
-            <field name="help" type="html">
-              <p class="o_view_nocontent_smiling_face">
-                Define a new medium
-              </p>
-            </field>
-        </record>
+                </group>
+            </form>
+        </field>
+    </record>
 
-        <menuitem action="utm_medium_action" id="menu_utm_medium" parent="marketing_utm" sequence="4" groups="base.group_no_one"/>
+    <record id="utm_medium_action" model="ir.actions.act_window">
+        <field name="name">Mediums</field>
+        <field name="res_model">utm.medium</field>
+        <field name="view_type">form</field>
+        <field name="view_mode">tree,form</field>
+        <field name="help" type="html">
+            <p class="o_view_nocontent_smiling_face">
+                Define a new UTM medium
+            </p>
+        </field>
+    </record>
 
-        <!-- utm.source -->
-        <record id="utm_source_view_tree" model="ir.ui.view">
-            <field name="name">utm.source.tree</field>
-            <field name="model">utm.source</field>
-            <field name="arch" type="xml">
-                <tree string="Medium">
+    <menuitem id="menu_utm_medium"
+        action="utm_medium_action"
+        parent="marketing_utm"
+        sequence="5"
+        groups="base.group_no_one"/>
+
+    <!-- utm.source -->
+    <record id="utm_source_view_tree" model="ir.ui.view">
+        <field name="name">utm.source.view.tree</field>
+        <field name="model">utm.source</field>
+        <field name="arch" type="xml">
+            <tree string="Source">
+                <field name="name"/>
+            </tree>
+        </field>
+    </record>
+    <record id="utm_source_view_form" model="ir.ui.view">
+        <field name="name">utm.source.view.form</field>
+        <field name="model">utm.source</field>
+        <field name="arch" type="xml">
+            <form string="Source">
+                <group>
                     <field name="name"/>
-                </tree>
-            </field>
-        </record>
-        <record id="utm_source_view_form" model="ir.ui.view">
-            <field name="name">utm.source.form</field>
-            <field name="model">utm.source</field>
-            <field name="arch" type="xml">
-                <form string="Channel">
-                    <group>
-                        <field name="name"/>
-                    </group>
-                </form>
-            </field>
-        </record>
-        <record id="utm_source_action" model="ir.actions.act_window">
-            <field name="name">Sources</field>
-            <field name="res_model">utm.source</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">tree,form</field>
-            <field name="help" type="html">
-              <p class="o_view_nocontent_smiling_face">
-                Define a new source
-              </p>
-            </field>
-        </record>
+                </group>
+            </form>
+        </field>
+    </record>
+
+    <record id="utm_source_action" model="ir.actions.act_window">
+        <field name="name">Sources</field>
+        <field name="res_model">utm.source</field>
+        <field name="view_type">form</field>
+        <field name="view_mode">tree,form</field>
+        <field name="help" type="html">
+            <p class="o_view_nocontent_smiling_face">
+                Define a new UTM source
+            </p>
+        </field>
+    </record>
+
+    <menuitem id="menu_utm_source"
+        action="utm_source_action"
+        parent="marketing_utm"
+        sequence="10"
+        groups="base.group_no_one"/>
 
-        <menuitem action="utm_source_action" id="menu_utm_source" parent="marketing_utm" sequence="4" groups="base.group_no_one"/>
 </odoo>