From 892c8ae572fd94673437eeb950ce36679bece6ac Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Mon, 10 Oct 2022 15:46:04 +0000
Subject: [PATCH] [FIX] sale: remove useless menu depth

Since the removal of the dashboard view(s), there isn't even a second
'Dashboard' menu being added by and enterprise module.

Therefore, there is no need to keep the 'Sales' menu hidden under the
'Reporting' one, the reporting one can lead directly to the `sale.report`
action (& views).

closes odoo/odoo#103161

X-original-commit: 61a471eaf72fced257f31ae05e61f12620a5d39c
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 addons/sale/views/sale_menus.xml                       | 10 ++--------
 .../data/files/product_dashboard.json                  |  6 +++---
 .../data/files/sales_dashboard.json                    |  6 +++---
 3 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/addons/sale/views/sale_menus.xml b/addons/sale/views/sale_menus.xml
index a21189662ae..57194c22eaf 100644
--- a/addons/sale/views/sale_menus.xml
+++ b/addons/sale/views/sale_menus.xml
@@ -72,15 +72,9 @@
 
         <menuitem id="menu_sale_report"
             name="Reporting"
+            action="action_order_report_all"
             groups="sales_team.group_sale_manager"
-            sequence="40">
-
-            <menuitem id="menu_report_product_all"
-                name="Sales"
-                action="action_order_report_all"
-                sequence="10"/>
-
-        </menuitem>
+            sequence="40"/>
 
         <menuitem id="menu_sale_config"
             name="Configuration"
diff --git a/addons/spreadsheet_dashboard_sale/data/files/product_dashboard.json b/addons/spreadsheet_dashboard_sale/data/files/product_dashboard.json
index e3bc1ff2b34..98b103c521a 100644
--- a/addons/spreadsheet_dashboard_sale/data/files/product_dashboard.json
+++ b/addons/spreadsheet_dashboard_sale/data/files/product_dashboard.json
@@ -677,8 +677,8 @@
         "30212d4a-1f77-4cb8-8590-4eb34876e260": "sale.sale_menu_root",
         "e35856cf-9090-489b-b055-2d441380d954": "sale.sale_menu_root",
         "d0171069-d2cd-4c2c-a686-cd7515e93bb5": "sale.sale_menu_root",
-        "5f383918-4073-4f19-9cc9-603216c953ad": "sale.menu_report_product_all",
-        "ec57f69b-f2b1-4dfc-990c-91ab61b526bf": "sale.menu_report_product_all"
+        "5f383918-4073-4f19-9cc9-603216c953ad": "sale.menu_sale_report",
+        "ec57f69b-f2b1-4dfc-990c-91ab61b526bf": "sale.menu_sale_report"
     },
     "odooVersion": 4,
     "lists": {},
@@ -849,4 +849,4 @@
             }
         }
     ]
-}
\ No newline at end of file
+}
diff --git a/addons/spreadsheet_dashboard_sale/data/files/sales_dashboard.json b/addons/spreadsheet_dashboard_sale/data/files/sales_dashboard.json
index 62b52e42355..70d70b8ab62 100644
--- a/addons/spreadsheet_dashboard_sale/data/files/sales_dashboard.json
+++ b/addons/spreadsheet_dashboard_sale/data/files/sales_dashboard.json
@@ -2430,8 +2430,8 @@
         "a527960b-0812-4291-baba-f6b4b5280a0d": "sale.sale_menu_root",
         "51823220-f22b-4359-8711-579a249c91bb": "sale.menu_sale_quotations",
         "9a38934c-b454-4a4b-88aa-17d1b80dbf5f": "sale.menu_sale_order",
-        "67858d0e-b5ba-4a3c-bf9e-c0fceaeedf65": "sale.menu_report_product_all",
-        "d43375c1-73a6-42a2-8dbd-0f13c285824f": "sale.menu_report_product_all"
+        "67858d0e-b5ba-4a3c-bf9e-c0fceaeedf65": "sale.menu_sale_report",
+        "d43375c1-73a6-42a2-8dbd-0f13c285824f": "sale.menu_sale_report"
     },
     "odooVersion": 4,
     "lists": {
@@ -3485,4 +3485,4 @@
             }
         }
     ]
-}
\ No newline at end of file
+}