From 89082fbd560959f1ab747dd2d027d027f68a3a0f Mon Sep 17 00:00:00 2001
From: Elisabeth Dickinson <edi@odoo.com>
Date: Wed, 16 Aug 2023 13:17:53 +0200
Subject: [PATCH] [IMP] web, *: fix favorite alignment

*: account, hr_recruitment, project, lunch, mrp

By removing the absolute positioning on ".o_favorite" inside kanban
views, we allow it to align naturally with the rest of the elements,
thus removing the custom code that was needed for padding.

By doing so however the icon - which is now only visible on hovering the
card in the Project's kanban view - should remain visible at all times.
The behaviour would be the same as in other kanban views: an outlined
star when not active and a full yellow star when it is.

The margin on the kanban heading in the Manufacturing orders has been
removed to realign the top elements.

task-3462098

closes odoo/odoo#131559

Signed-off-by: Pierre Paridans (app) <app@odoo.com>
---
 .../views/account_journal_dashboard_view.xml   |  4 +---
 addons/hr_recruitment/views/hr_job_views.xml   | 12 ++++++------
 addons/mrp/views/mrp_production_views.xml      |  2 +-
 .../static/src/scss/project_dashboard.scss     | 10 ----------
 addons/project/views/project_project_views.xml |  6 ++----
 .../src/views/kanban/kanban_dashboard.scss     | 18 ------------------
 6 files changed, 10 insertions(+), 42 deletions(-)

diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index 506d42368c2..95c937ff0f6 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -206,9 +206,7 @@
                             </div>
 
                             <div groups="account.group_account_manager" class="row o_kanban_card_manage_settings">
-                                <div class="col-6 position-relative mt-n2">
-                                    <field name="show_on_dashboard" widget="boolean_favorite"/>
-                                </div>
+                                <field name="show_on_dashboard" widget="boolean_favorite" class="col-6"/>
                                 <div class="col-6 text-end">
                                     <a class="dropdown-item" t-if="widget.editable" type="edit">Configuration</a>
                                 </div>
diff --git a/addons/hr_recruitment/views/hr_job_views.xml b/addons/hr_recruitment/views/hr_job_views.xml
index bf017cb6add..6968f0d6c84 100644
--- a/addons/hr_recruitment/views/hr_job_views.xml
+++ b/addons/hr_recruitment/views/hr_job_views.xml
@@ -73,19 +73,19 @@
                     </t>
                     <t t-name="kanban-box">
                         <div t-attf-class="#{!selection_mode ? kanban_color(record.color.raw_value) : ''}">
-                            <div class="o_kanban_card_header">
+                            <div class="o_kanban_card_header d-flex align-items-baseline gap-1">
+                                <field name="is_favorite" widget="boolean_favorite" nolabel="1"/>
                                 <div class="o_kanban_card_header_title">
-                                    <field name="is_favorite" widget="boolean_favorite" nolabel="1"/>
-                                    <div class="o_primary ps-3">
+                                    <div class="o_primary">
                                         <span class="o_text_overflow"><t t-esc="record.name.value"/></span>
                                     </div>
-                                    <div class="ps-3 text-muted">
+                                    <div class="text-muted">
                                         <field name="user_id" />
                                     </div>
-                                    <div class="ps-3 o_secondary" groups="base.group_multi_company">
+                                    <div class="o_secondary" groups="base.group_multi_company">
                                         <small><i class="fa fa-building-o" role="img" aria-label="Company" title="Company"></i> <field name="company_id"/></small>
                                     </div>
-                                    <div t-if="record.alias_email.value" class="ps-3 o_secondary o_job_alias">
+                                    <div t-if="record.alias_email.value" class="o_secondary o_job_alias">
                                         <small><i class="fa fa-envelope-o" role="img" aria-label="Alias" title="Alias"></i> <field name="alias_id"/></small>
                                     </div>
                                 </div>
diff --git a/addons/mrp/views/mrp_production_views.xml b/addons/mrp/views/mrp_production_views.xml
index 779f394c692..caf132c194e 100644
--- a/addons/mrp/views/mrp_production_views.xml
+++ b/addons/mrp/views/mrp_production_views.xml
@@ -520,7 +520,7 @@
                             <div t-attf-class="oe_kanban_card oe_kanban_global_click">
                                 <div class="o_kanban_record_top">
                                     <field name="priority" widget="priority"/>
-                                    <div class="o_kanban_record_headings mt4 ms-1">
+                                    <div class="o_kanban_record_headings ms-1">
                                         <strong class="o_kanban_record_title"><span><t t-esc="record.product_id.value"/></span></strong>
                                     </div>
                                     <span class="float-end text-end"><t t-esc="record.product_qty.value"/> <small><t t-esc="record.product_uom_id.value"/></small></span>
diff --git a/addons/project/static/src/scss/project_dashboard.scss b/addons/project/static/src/scss/project_dashboard.scss
index c8c51292b80..b9a50166537 100644
--- a/addons/project/static/src/scss/project_dashboard.scss
+++ b/addons/project/static/src/scss/project_dashboard.scss
@@ -22,7 +22,6 @@
 
             &:first-child {
                  margin: 0 5px 0 0;
-                 padding-left: 12px
              }
 
             .o_value {
@@ -56,15 +55,6 @@
             top: 15%;
         }
     }
-
-    .o_kanban_record {
-        div[name="is_favorite"] .fa-star-o {
-            visibility: hidden;
-        }
-        &:hover div[name="is_favorite"] .fa-star-o {
-            visibility: visible;
-        }
-    }
 }
 
 .o_dow_widget {
diff --git a/addons/project/views/project_project_views.xml b/addons/project/views/project_project_views.xml
index 31b8f7fa3be..032366bd99e 100644
--- a/addons/project/views/project_project_views.xml
+++ b/addons/project/views/project_project_views.xml
@@ -452,7 +452,8 @@
                         </t>
                         <t t-name="kanban-box">
                             <div t-attf-class="#{kanban_color(record.color.raw_value)} oe_kanban_global_click o_has_icon oe_kanban_content oe_kanban_card">
-                                <div class="o_project_kanban_main ">
+                                <div class="o_project_kanban_main d-flex align-items-baseline gap-1">
+                                    <field name="is_favorite" widget="boolean_favorite" nolabel="1" force_save="1"/>
                                     <div class="o_kanban_card_content mw-100">
                                         <div class="o_kanban_primary_left">
                                             <div class="o_primary">
@@ -485,9 +486,6 @@
                                             </div>
                                         </div>
                                     </div>
-                                    <span>
-                                       <field name="is_favorite" widget="boolean_favorite" nolabel="1" force_save="1" />
-                                    </span>
                                 </div>
                                 <div class="o_kanban_record_bottom mt-3">
                                     <div class="oe_kanban_bottom_left">
diff --git a/addons/web/static/src/views/kanban/kanban_dashboard.scss b/addons/web/static/src/views/kanban/kanban_dashboard.scss
index 155a0aa6c8a..428c56792ef 100644
--- a/addons/web/static/src/views/kanban/kanban_dashboard.scss
+++ b/addons/web/static/src/views/kanban/kanban_dashboard.scss
@@ -27,11 +27,6 @@
         // -------  Kanban Record Titles -------
         // Uniform design across different HTML layouts
 
-        // Provide enough room for the dropdown-toggle
-        .o_primary {
-            padding-right: calc(var(--KanbanRecord-padding-h) * 2);
-        }
-
         // Uniform titles
         .o_kanban_card_header_title .o_primary,
         .o_kanban_primary_left .o_primary > span:first-child,
@@ -47,11 +42,6 @@
             color: $text-muted;
         }
 
-        // Provide enough room to add an icon before the title
-        &.o_has_icon .o_primary {
-            padding-left: $o-kanban-record-margin*1.5;
-        }
-
         // -------  Kanban Content -------
         .o_kanban_card_content {
             display: inline-block;
@@ -184,14 +174,6 @@
         }
 
     }
-
-    .o_favorite {
-        @include o-position-absolute(
-            $top: 3px,
-            $left: calc(var(--KanbanRecord-padding-h) - #{$o-horizontal-padding})
-        );
-        padding: $o-kanban-record-margin;
-    }
 }
 
 .o_kanban_dashboard.o_emphasize_colors .o_kanban_renderer {