From 890371d98290c5c50fd6bce0636e0f3fbded7cae Mon Sep 17 00:00:00 2001
From: Stephane Wirtel <stw@openerp.com>
Date: Fri, 17 Aug 2012 17:15:29 +0200
Subject: [PATCH] [IMP] point_of_sale: fix some typo [FIX] point_of_sale: add
 some groups

bzr revid: stw@openerp.com-20120817151529-1kkm9m5g5ob291ur
---
 addons/point_of_sale/point_of_sale.py               |  4 ++--
 addons/point_of_sale/point_of_sale_view.xml         |  6 +++---
 addons/point_of_sale/wizard/pos_session_opening.py  | 10 ++++++++--
 addons/point_of_sale/wizard/pos_session_opening.xml |  2 +-
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/addons/point_of_sale/point_of_sale.py b/addons/point_of_sale/point_of_sale.py
index 15a9cb85ed4..414ff1c3302 100644
--- a/addons/point_of_sale/point_of_sale.py
+++ b/addons/point_of_sale/point_of_sale.py
@@ -73,7 +73,7 @@ class pos_config(osv.osv):
             help="This sequence is automatically created by OpenERP but you can change it "\
                 "to customize the reference numbers of your orders."),
         'session_ids': fields.one2many('pos.session', 'config_id', 'Sessions'),
-        'group_by' : fields.boolean('Group By', help="Check this if you want to group the Journal Items by Product while closing a Session"),
+        'group_by' : fields.boolean('Group Journal Items', help="Check this if you want to group the Journal Items by Product while closing a Session"),
     }
 
     def name_get(self, cr, uid, ids, context=None):
@@ -89,7 +89,7 @@ class pos_config(osv.osv):
                 result.append((record.id, record.name+' ('+_('not used')+')'))
                 continue
             session = record.session_ids[0]
-            result.append((record.id, record.name + ' ('+session.user_id.name+', '+states[session.state]+')'))
+            result.append((record.id, record.name + ' ('+session.user_id.name+')')) #, '+states[session.state]+')'))
         return result
 
 
diff --git a/addons/point_of_sale/point_of_sale_view.xml b/addons/point_of_sale/point_of_sale_view.xml
index 1a1e0442c16..e40cbc756b8 100644
--- a/addons/point_of_sale/point_of_sale_view.xml
+++ b/addons/point_of_sale/point_of_sale_view.xml
@@ -776,10 +776,10 @@
                     <sheet>
                         <group>
                         <field name="name"/>
-                        <field name="shop_id" widget="selection" />
+                        <field name="shop_id" widget="selection" groups="stock.group_locations" />
                         <field name="journal_id" widget="selection" />
-                        <field name="sequence_id" readonly="1"/>
-                        <field name="group_by" />
+                        <field name="sequence_id" readonly="1" groups="base.group_no_one" />
+                        <field name="group_by" groups="account.group_account_user"  />
                         </group>
                         <separator string="Available Payment Methods" colspan="4"/>
                         <field name="journal_ids" colspan="4" nolabel="1">
diff --git a/addons/point_of_sale/wizard/pos_session_opening.py b/addons/point_of_sale/wizard/pos_session_opening.py
index f7f231b3aa0..056856d8365 100644
--- a/addons/point_of_sale/wizard/pos_session_opening.py
+++ b/addons/point_of_sale/wizard/pos_session_opening.py
@@ -10,7 +10,7 @@ class pos_session_opening(osv.osv_memory):
     _columns = {
         'pos_config_id' : fields.many2one('pos.config', 'Point of Sale', required=True),
         'pos_session_id' : fields.many2one('pos.session', 'PoS Session'),
-        'pos_state' : fields.char('Session State'),
+        'pos_state' : fields.char('Session State', readonly=True),
     }
 
     def open_ui(self, cr, uid, ids, context=None):
@@ -60,6 +60,12 @@ class pos_session_opening(osv.osv_memory):
         }
 
     def on_change_config(self, cr, uid, ids, config_id, context=None):
+        states = {
+            'opening_control': _('Opening Control'),
+            'opened': _('In Progress'),
+            'closing_control': _('Closing Control'),
+            'closed': _('Closed & Posted'),
+        }
         result = {
             'pos_session_id': False,
             'pos_state': False
@@ -72,7 +78,7 @@ class pos_session_opening(osv.osv_memory):
             ('config_id', '=', config_id),
         ], context=context)
         if session_ids:
-            result['pos_state'] = proxy.browse(cr, uid, session_ids[0], context=context).state
+            result['pos_state'] = states.get(proxy.browse(cr, uid, session_ids[0], context=context).state, False)
             result['pos_session_id'] = session_ids[0]
         return {'value' : result}
 
diff --git a/addons/point_of_sale/wizard/pos_session_opening.xml b/addons/point_of_sale/wizard/pos_session_opening.xml
index 38f8932bd56..8711aa5e5fb 100644
--- a/addons/point_of_sale/wizard/pos_session_opening.xml
+++ b/addons/point_of_sale/wizard/pos_session_opening.xml
@@ -11,9 +11,9 @@
                         <field name="pos_config_id" on_change="on_change_config(pos_config_id)"
                             widget="selection" domain="[('state','=','active')]"
                             class="oe_inline"/>
+                        <field name="pos_state" class="oe_inline" attrs="{'invisible' : [('pos_state', '=', False)]}" />
                     </group>
                     <field name="pos_session_id" invisible="1"/>
-                    <field name="pos_state" invisible="1"/>
                     <button name="open_ui" type="object" string="Start Selling" 
                         attrs="{'invisible' : [('pos_state', 'not in', ('opened',))]}" 
                         class="oe_highlight"