From 88c328bcd050e935c8fc95a152b9b140116a5676 Mon Sep 17 00:00:00 2001 From: Nicolas Martinelli Date: Thu, 2 Jul 2020 12:46:47 +0000 Subject: [PATCH] [FIX] web: do not suggest translation for empty HTML field - Activate more than one language - Install sale_quotation_builder - Create a new quotation model without website description - Create a SO using this model, Save The 'Please update translations of' is displayed for the website desctiption, although it is empty: when clicking on the link, no record is shown. This happens because an empty HTML field always contains at least `


`. We do not consider the latter string for translation. opw-2274203 closes odoo/odoo#54025 X-original-commit: aad4d516b6fb4b286f24bc536e5ecb67558a0c4d Signed-off-by: Nicolas Martinelli (nim) --- addons/web/static/src/js/views/form/form_controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/js/views/form/form_controller.js b/addons/web/static/src/js/views/form/form_controller.js index 30eea51d740..c3acdf71e0a 100644 --- a/addons/web/static/src/js/views/form/form_controller.js +++ b/addons/web/static/src/js/views/form/form_controller.js @@ -248,7 +248,7 @@ var FormController = BasicController.extend({ for (var k = 0; k < changedFields.length; k++) { var field = fields[changedFields[k]]; var fieldData = data[changedFields[k]]; - if (field.translate && fieldData) { + if (field.translate && fieldData && fieldData !== '


') { alertFields[changedFields[k]] = field; } }